From b187d33a78a1ad4ff99e4490a51aa1e542a1931d Mon Sep 17 00:00:00 2001 From: Dean Sheather Date: Thu, 18 Dec 2025 16:04:03 +1100 Subject: [PATCH] fix: show exclamation mark on negated permissions in org custom roles page (#21314) Some permissions (in built-in roles only) have `Negated: true`, so the UI was misleading users by showing that they had those permissions when they really didn't. image --- .../CustomRolesPage/PermissionPillsList.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/site/src/pages/OrganizationSettingsPage/CustomRolesPage/PermissionPillsList.tsx b/site/src/pages/OrganizationSettingsPage/CustomRolesPage/PermissionPillsList.tsx index 9ff1a524a8..bce0da5915 100644 --- a/site/src/pages/OrganizationSettingsPage/CustomRolesPage/PermissionPillsList.tsx +++ b/site/src/pages/OrganizationSettingsPage/CustomRolesPage/PermissionPillsList.tsx @@ -59,7 +59,8 @@ const PermissionsPill: FC = ({ return ( - {resource}: {actions.map((p) => p.action).join(", ")} + {resource}:{" "} + {actions.map((p) => `${p.negate ? "!" : ""}${p.action}`).join(", ")} ); };