chore: revert feat(enterprise/coderd): allow system users to be added to groups (#19254)

This reverts commit b200fc8e67
(https://github.com/coder/coder/pull/18341).

coderd/database/dbauthz/dbauthz.go

@@ -485,16 +485,6 @@ var (
 					rbac.ResourceFile.Type: {
 						policy.ActionRead,
 					},
-					// Needs to be able to add the prebuilds system user to the "prebuilds" group in each organization that needs prebuilt workspaces
-					// so that prebuilt workspaces can be scheduled and owned in those organizations.
-					rbac.ResourceGroup.Type: {
-						policy.ActionRead,
-						policy.ActionCreate,
-						policy.ActionUpdate,
-					},
-					rbac.ResourceGroupMember.Type: {
-						policy.ActionRead,
-					},
 				}),
 			},
 		}),

coderd/database/queries.sql.go

@@ -6592,19 +6592,16 @@ WHERE
 			organization_id = $1
 		ELSE true
 	END
-  -- Filter by system type
-	AND CASE WHEN $2::bool THEN TRUE ELSE is_system = false END
 ORDER BY
 	-- Deterministic and consistent ordering of all users. This is to ensure consistent pagination.
-	LOWER(username) ASC OFFSET $3
+	LOWER(username) ASC OFFSET $2
 LIMIT
 	-- A null limit means "no limit", so 0 means return all
-	NULLIF($4 :: int, 0)
+	NULLIF($3 :: int, 0)
 `
 
 type PaginatedOrganizationMembersParams struct {
 	OrganizationID uuid.UUID `db:"organization_id" json:"organization_id"`
-	IncludeSystem  bool      `db:"include_system" json:"include_system"`
 	OffsetOpt      int32     `db:"offset_opt" json:"offset_opt"`
 	LimitOpt       int32     `db:"limit_opt" json:"limit_opt"`
 }
@@ -6620,12 +6617,7 @@ type PaginatedOrganizationMembersRow struct {
 }
 
 func (q *sqlQuerier) PaginatedOrganizationMembers(ctx context.Context, arg PaginatedOrganizationMembersParams) ([]PaginatedOrganizationMembersRow, error) {
-	rows, err := q.db.QueryContext(ctx, paginatedOrganizationMembers,
-		arg.OrganizationID,
-		arg.IncludeSystem,
-		arg.OffsetOpt,
-		arg.LimitOpt,
-	)
+	rows, err := q.db.QueryContext(ctx, paginatedOrganizationMembers, arg.OrganizationID, arg.OffsetOpt, arg.LimitOpt)
 	if err != nil {
 		return nil, err
 	}

coderd/database/queries/organizationmembers.sql

@@ -89,8 +89,6 @@ WHERE
 			organization_id = @organization_id
 		ELSE true
 	END
-  -- Filter by system type
-	AND CASE WHEN @include_system::bool THEN TRUE ELSE is_system = false END
 ORDER BY
 	-- Deterministic and consistent ordering of all users. This is to ensure consistent pagination.
 	LOWER(username) ASC OFFSET @offset_opt

coderd/members.go

@@ -203,7 +203,6 @@ func (api *API) paginatedMembers(rw http.ResponseWriter, r *http.Request) {
 
 	paginatedMemberRows, err := api.Database.PaginatedOrganizationMembers(ctx, database.PaginatedOrganizationMembersParams{
 		OrganizationID: organization.ID,
-		IncludeSystem:  false,
 		// #nosec G115 - Pagination limits are small and fit in int32
 		LimitOpt: int32(paginationParams.Limit),
 		// #nosec G115 - Pagination offsets are small and fit in int32