feat: make ephemeral parameters optional (#8571)

cli/create.go

@@ -23,8 +23,6 @@ func (r *RootCmd) create() *clibase.Cmd {
 		startAt           string
 		stopAfter         time.Duration
 		workspaceName     string
-
-		parameterFlags workspaceParameterFlags
 	)
 	client := new(codersdk.Client)
 	cmd := &clibase.Cmd{
@@ -135,7 +133,6 @@ func (r *RootCmd) create() *clibase.Cmd {
 				Template:          template,
 				RichParameterFile: richParameterFile,
 				NewWorkspaceName:  workspaceName,
-				BuildOptions:      parameterFlags.buildOptions,
 			})
 			if err != nil {
 				return xerrors.Errorf("prepare build: %w", err)
@@ -204,8 +201,6 @@ func (r *RootCmd) create() *clibase.Cmd {
 		},
 		cliui.SkipPromptOption(),
 	)
-	cmd.Options = append(cmd.Options, parameterFlags.options()...)
-
 	return cmd
 }
 

cli/create_test.go

@@ -252,10 +252,6 @@ func TestCreateWithRichParameters(t *testing.T) {
 		secondParameterDescription = "This is second parameter"
 		secondParameterValue       = "2"
 
-		ephemeralParameterName        = "ephemeral_parameter"
-		ephemeralParameterDescription = "This is ephemeral parameter"
-		ephemeralParameterValue       = "3"
-
 		immutableParameterName        = "third_parameter"
 		immutableParameterDescription = "This is not mutable parameter"
 		immutableParameterValue       = "4"
@@ -270,7 +266,6 @@ func TestCreateWithRichParameters(t *testing.T) {
 						Parameters: []*proto.RichParameter{
 							{Name: firstParameterName, Description: firstParameterDescription, Mutable: true},
 							{Name: secondParameterName, DisplayName: secondParameterDisplayName, Description: secondParameterDescription, Mutable: true},
-							{Name: ephemeralParameterName, Description: ephemeralParameterDescription, Mutable: true, Ephemeral: true},
 							{Name: immutableParameterName, Description: immutableParameterDescription, Mutable: false},
 						},
 					},
@@ -362,60 +357,6 @@ func TestCreateWithRichParameters(t *testing.T) {
 		}
 		<-doneChan
 	})
-
-	t.Run("BuildOptions", func(t *testing.T) {
-		t.Parallel()
-
-		client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerDaemon: true})
-		user := coderdtest.CreateFirstUser(t, client)
-		version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, echoResponses)
-		coderdtest.AwaitTemplateVersionJob(t, client, version.ID)
-
-		template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
-
-		const workspaceName = "my-workspace"
-		inv, root := clitest.New(t, "create", workspaceName, "--template", template.Name, "--build-options")
-		clitest.SetupConfig(t, client, root)
-		doneChan := make(chan struct{})
-		pty := ptytest.New(t).Attach(inv)
-		go func() {
-			defer close(doneChan)
-			err := inv.Run()
-			assert.NoError(t, err)
-		}()
-
-		matches := []string{
-			ephemeralParameterDescription, ephemeralParameterValue,
-			firstParameterDescription, firstParameterValue,
-			secondParameterDisplayName, "",
-			secondParameterDescription, secondParameterValue,
-			immutableParameterDescription, immutableParameterValue,
-			"Confirm create?", "yes",
-		}
-		for i := 0; i < len(matches); i += 2 {
-			match := matches[i]
-			value := matches[i+1]
-			pty.ExpectMatch(match)
-
-			if value != "" {
-				pty.WriteLine(value)
-			}
-		}
-		<-doneChan
-
-		// Verify if build option is set
-		ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitShort)
-		defer cancel()
-
-		workspace, err := client.WorkspaceByOwnerAndName(ctx, user.UserID.String(), workspaceName, codersdk.WorkspaceOptions{})
-		require.NoError(t, err)
-		actualParameters, err := client.WorkspaceBuildParameters(ctx, workspace.LatestBuild.ID)
-		require.NoError(t, err)
-		require.Contains(t, actualParameters, codersdk.WorkspaceBuildParameter{
-			Name:  ephemeralParameterName,
-			Value: ephemeralParameterValue,
-		})
-	})
 }
 
 func TestCreateValidateRichParameters(t *testing.T) {

cli/start.go

@@ -11,7 +11,7 @@ import (
 	"github.com/coder/coder/codersdk"
 )
 
-// workspaceParameterFlags are used by "start", "restart", "create", and "update".
+// workspaceParameterFlags are used by "start", "restart", and "update".
 type workspaceParameterFlags struct {
 	buildOptions bool
 }

cli/testdata/coder_create_--help.golden

@@ -7,9 +7,6 @@ Create a workspace
       $ coder create <username>/<workspace_name> 
 
 Options
-      --build-options bool
-          Prompt for one-time build options defined with ephemeral parameters.
-
       --rich-parameter-file string, $CODER_RICH_PARAMETER_FILE
           Specify a file path with values for rich parameters defined in the
           template.