refactor(coderd): drop sidebar app constraint and simplify provisionerdserver for tasks (#20591)

Updates coder/internal#973
Updates coder/internal#974

coderd/database/check_constraint.go

@@ -6,15 +6,14 @@ type CheckConstraint string
 
 // CheckConstraint enums.
 const (
-	CheckAPIKeysAllowListNotEmpty                  CheckConstraint = "api_keys_allow_list_not_empty"                    // api_keys
-	CheckOneTimePasscodeSet                        CheckConstraint = "one_time_passcode_set"                            // users
-	CheckUsersUsernameMinLength                    CheckConstraint = "users_username_min_length"                        // users
-	CheckMaxProvisionerLogsLength                  CheckConstraint = "max_provisioner_logs_length"                      // provisioner_jobs
-	CheckMaxLogsLength                             CheckConstraint = "max_logs_length"                                  // workspace_agents
-	CheckSubsystemsNotNone                         CheckConstraint = "subsystems_not_none"                              // workspace_agents
-	CheckWorkspaceBuildsAiTaskSidebarAppIDRequired CheckConstraint = "workspace_builds_ai_task_sidebar_app_id_required" // workspace_builds
-	CheckWorkspaceBuildsDeadlineBelowMaxDeadline   CheckConstraint = "workspace_builds_deadline_below_max_deadline"     // workspace_builds
-	CheckTelemetryLockEventTypeConstraint          CheckConstraint = "telemetry_lock_event_type_constraint"             // telemetry_locks
-	CheckValidationMonotonicOrder                  CheckConstraint = "validation_monotonic_order"                       // template_version_parameters
-	CheckUsageEventTypeCheck                       CheckConstraint = "usage_event_type_check"                           // usage_events
+	CheckAPIKeysAllowListNotEmpty                CheckConstraint = "api_keys_allow_list_not_empty"                // api_keys
+	CheckOneTimePasscodeSet                      CheckConstraint = "one_time_passcode_set"                        // users
+	CheckUsersUsernameMinLength                  CheckConstraint = "users_username_min_length"                    // users
+	CheckMaxProvisionerLogsLength                CheckConstraint = "max_provisioner_logs_length"                  // provisioner_jobs
+	CheckMaxLogsLength                           CheckConstraint = "max_logs_length"                              // workspace_agents
+	CheckSubsystemsNotNone                       CheckConstraint = "subsystems_not_none"                          // workspace_agents
+	CheckWorkspaceBuildsDeadlineBelowMaxDeadline CheckConstraint = "workspace_builds_deadline_below_max_deadline" // workspace_builds
+	CheckTelemetryLockEventTypeConstraint        CheckConstraint = "telemetry_lock_event_type_constraint"         // telemetry_locks
+	CheckValidationMonotonicOrder                CheckConstraint = "validation_monotonic_order"                   // template_version_parameters
+	CheckUsageEventTypeCheck                     CheckConstraint = "usage_event_type_check"                       // usage_events
 )

coderd/database/dump.sql

@@ -1950,7 +1950,6 @@ CREATE TABLE workspace_builds (
     has_ai_task boolean,
     ai_task_sidebar_app_id uuid,
     has_external_agent boolean,
-    CONSTRAINT workspace_builds_ai_task_sidebar_app_id_required CHECK (((((has_ai_task IS NULL) OR (has_ai_task = false)) AND (ai_task_sidebar_app_id IS NULL)) OR ((has_ai_task = true) AND (ai_task_sidebar_app_id IS NOT NULL)))),
     CONSTRAINT workspace_builds_deadline_below_max_deadline CHECK ((((deadline <> '0001-01-01 00:00:00+00'::timestamp with time zone) AND (deadline <= max_deadline)) OR (max_deadline = '0001-01-01 00:00:00+00'::timestamp with time zone)))
 );
 

coderd/database/migrations/000394_drop_workspace_build_ai_task_sidebar_app_id_required.down.sql

@@ -0,0 +1,4 @@
+-- WARNING: Restoring this constraint after running a newer version of coderd
+-- and using tasks is bound to break this constraint.
+ALTER TABLE workspace_builds
+ADD CONSTRAINT workspace_builds_ai_task_sidebar_app_id_required CHECK (((((has_ai_task IS NULL) OR (has_ai_task = false)) AND (ai_task_sidebar_app_id IS NULL)) OR ((has_ai_task = true) AND (ai_task_sidebar_app_id IS NOT NULL))));

coderd/database/migrations/000394_drop_workspace_build_ai_task_sidebar_app_id_required.up.sql

@@ -0,0 +1,4 @@
+-- We no longer need to enforce this constraint as tasks have their own data
+-- model.
+ALTER TABLE workspace_builds
+DROP CONSTRAINT workspace_builds_ai_task_sidebar_app_id_required;