From a67a5a81053ecf18b5d81e9909fcab5ec9ba6021 Mon Sep 17 00:00:00 2001
From: Asher <ash@coder.com>
Date: Wed, 11 Oct 2023 12:47:32 -0800
Subject: [PATCH] Prevent terminal being created twice (#10200)

I missed this in code review.
---
 site/src/pages/TerminalPage/TerminalPage.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/site/src/pages/TerminalPage/TerminalPage.tsx b/site/src/pages/TerminalPage/TerminalPage.tsx
index 958d7ef732..dfc52c8a91 100644
--- a/site/src/pages/TerminalPage/TerminalPage.tsx
+++ b/site/src/pages/TerminalPage/TerminalPage.tsx
@@ -154,7 +154,7 @@ const TerminalPage: FC = () => {
 
   // Create the terminal!
   useEffect(() => {
-    if (!xtermRef.current) {
+    if (!xtermRef.current || config.isLoading) {
       return;
     }
     const terminal = new XTerm.Terminal({
@@ -210,7 +210,7 @@ const TerminalPage: FC = () => {
       window.removeEventListener("resize", listener);
       terminal.dispose();
     };
-  }, [config.data, sendEvent, xtermRef, handleWebLink]);
+  }, [config.data, config.isLoading, sendEvent, xtermRef, handleWebLink]);
 
   // Triggers the initial terminal connection using
   // the reconnection token and workspace name found