From a546a859750e87208a3f742de0a640ba2703fac4 Mon Sep 17 00:00:00 2001
From: Mathias Fredriksson <mafredri@gmail.com>
Date: Wed, 5 Feb 2025 17:04:35 +0200
Subject: [PATCH] fix(coderd): set default provisionerjobs limit to 50 (#16450)

---
 coderd/provisionerjobs.go      |  2 +-
 coderd/provisionerjobs_test.go | 11 +++++++++--
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/coderd/provisionerjobs.go b/coderd/provisionerjobs.go
index 591c60855a..647274d9c2 100644
--- a/coderd/provisionerjobs.go
+++ b/coderd/provisionerjobs.go
@@ -101,7 +101,7 @@ func (api *API) handleAuthAndFetchProvisionerJobs(rw http.ResponseWriter, r *htt
 
 	qp := r.URL.Query()
 	p := httpapi.NewQueryParamParser()
-	limit := p.PositiveInt32(qp, 0, "limit")
+	limit := p.PositiveInt32(qp, 50, "limit")
 	status := p.Strings(qp, nil, "status")
 	p.ErrorExcessParams(qp)
 	if len(p.Errors) > 0 {
diff --git a/coderd/provisionerjobs_test.go b/coderd/provisionerjobs_test.go
index a8fd4f2a96..098e118327 100644
--- a/coderd/provisionerjobs_test.go
+++ b/coderd/provisionerjobs_test.go
@@ -63,6 +63,13 @@ func TestProvisionerJobs(t *testing.T) {
 		TemplateVersionID: version.ID,
 	})
 
+	// Add more jobs than the default limit.
+	for range 60 {
+		dbgen.ProvisionerJob(t, db, nil, database.ProvisionerJob{
+			OrganizationID: owner.OrganizationID,
+		})
+	}
+
 	t.Run("Single", func(t *testing.T) {
 		t.Parallel()
 		t.Run("OK", func(t *testing.T) {
@@ -82,12 +89,12 @@ func TestProvisionerJobs(t *testing.T) {
 		})
 	})
 
-	t.Run("All", func(t *testing.T) {
+	t.Run("Default limit", func(t *testing.T) {
 		t.Parallel()
 		ctx := testutil.Context(t, testutil.WaitMedium)
 		jobs, err := templateAdminClient.OrganizationProvisionerJobs(ctx, owner.OrganizationID, nil)
 		require.NoError(t, err)
-		require.Len(t, jobs, 3)
+		require.Len(t, jobs, 50)
 	})
 
 	t.Run("Status", func(t *testing.T) {