From a3f63080069c7f785b3e0f4e031459c6b9c711dd Mon Sep 17 00:00:00 2001 From: Sas Swart Date: Tue, 18 Mar 2025 14:47:30 +0200 Subject: [PATCH] fix: rewrite login type migrations (#16978) When trying to add [system users](https://github.com/coder/coder/pull/16916), we discovered an issue in two migrations that added values to the login_type enum. After some [consideration](https://github.com/coder/coder/pull/16916#discussion_r1998758887), we decided to retroactively correct them. --- .../migrations/000126_login_type_none.up.sql | 32 +++++++++++++++++-- .../000195_oauth2_provider_codes.up.sql | 28 +++++++++++++++- 2 files changed, 57 insertions(+), 3 deletions(-) diff --git a/coderd/database/migrations/000126_login_type_none.up.sql b/coderd/database/migrations/000126_login_type_none.up.sql index 75235e7d9c..60c1dfd787 100644 --- a/coderd/database/migrations/000126_login_type_none.up.sql +++ b/coderd/database/migrations/000126_login_type_none.up.sql @@ -1,3 +1,31 @@ -ALTER TYPE login_type ADD VALUE IF NOT EXISTS 'none'; +-- This migration has been modified after its initial commit. +-- The new implementation makes the same changes as the original, but +-- takes into account the message in create_migration.sh. This is done +-- to allow the insertion of a user with the "none" login type in later migrations. -COMMENT ON TYPE login_type IS 'Specifies the method of authentication. "none" is a special case in which no authentication method is allowed.'; +CREATE TYPE new_logintype AS ENUM ( + 'password', + 'github', + 'oidc', + 'token', + 'none' +); +COMMENT ON TYPE new_logintype IS 'Specifies the method of authentication. "none" is a special case in which no authentication method is allowed.'; + +ALTER TABLE users + ALTER COLUMN login_type DROP DEFAULT, + ALTER COLUMN login_type TYPE new_logintype USING (login_type::text::new_logintype), + ALTER COLUMN login_type SET DEFAULT 'password'::new_logintype; + +DROP INDEX IF EXISTS idx_api_key_name; +ALTER TABLE api_keys + ALTER COLUMN login_type TYPE new_logintype USING (login_type::text::new_logintype); +CREATE UNIQUE INDEX idx_api_key_name +ON api_keys (user_id, token_name) +WHERE (login_type = 'token'::new_logintype); + +ALTER TABLE user_links + ALTER COLUMN login_type TYPE new_logintype USING (login_type::text::new_logintype); + +DROP TYPE login_type; +ALTER TYPE new_logintype RENAME TO login_type; diff --git a/coderd/database/migrations/000195_oauth2_provider_codes.up.sql b/coderd/database/migrations/000195_oauth2_provider_codes.up.sql index d21d947d07..04333c0ed2 100644 --- a/coderd/database/migrations/000195_oauth2_provider_codes.up.sql +++ b/coderd/database/migrations/000195_oauth2_provider_codes.up.sql @@ -43,7 +43,33 @@ AFTER DELETE ON oauth2_provider_app_tokens FOR EACH ROW EXECUTE PROCEDURE delete_deleted_oauth2_provider_app_token_api_key(); -ALTER TYPE login_type ADD VALUE IF NOT EXISTS 'oauth2_provider_app'; +CREATE TYPE new_logintype AS ENUM ( + 'password', + 'github', + 'oidc', + 'token', + 'none', + 'oauth2_provider_app' +); +COMMENT ON TYPE new_logintype IS 'Specifies the method of authentication. "none" is a special case in which no authentication method is allowed.'; + +ALTER TABLE users + ALTER COLUMN login_type DROP DEFAULT, + ALTER COLUMN login_type TYPE new_logintype USING (login_type::text::new_logintype), + ALTER COLUMN login_type SET DEFAULT 'password'::new_logintype; + +DROP INDEX IF EXISTS idx_api_key_name; +ALTER TABLE api_keys + ALTER COLUMN login_type TYPE new_logintype USING (login_type::text::new_logintype); +CREATE UNIQUE INDEX idx_api_key_name +ON api_keys (user_id, token_name) +WHERE (login_type = 'token'::new_logintype); + +ALTER TABLE user_links + ALTER COLUMN login_type TYPE new_logintype USING (login_type::text::new_logintype); + +DROP TYPE login_type; +ALTER TYPE new_logintype RENAME TO login_type; -- Switch to an ID we will prefix to the raw secret that we give to the user -- (instead of matching on the entire secret as the ID, since they will be