From a361673ad8c1abbd8dce6b19d8788c3ac3ee14ba Mon Sep 17 00:00:00 2001 From: Steven Masley Date: Wed, 5 Apr 2023 12:47:40 -0500 Subject: [PATCH] fix: Include 'CODER' env var prefix on group mappings (#7015) * fix: Include 'CODER' env var prefix on group mappings * Unit test to force CODER prefix --- codersdk/deployment_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/codersdk/deployment_test.go b/codersdk/deployment_test.go index 3d73734b1c..ea48c1fbdd 100644 --- a/codersdk/deployment_test.go +++ b/codersdk/deployment_test.go @@ -1,6 +1,7 @@ package codersdk_test import ( + "strings" "testing" "github.com/stretchr/testify/require" @@ -101,6 +102,12 @@ func TestDeploymentValues_HighlyConfigurable(t *testing.T) { t.Errorf("Option %q is excluded but has an env name", opt.Name) } + // Also check all env vars are prefixed with CODER_ + const prefix = "CODER_" + if opt.Env != "" && !strings.HasPrefix(opt.Env, prefix) { + t.Errorf("Option %q has an env name (%q) that is not prefixed with %s", opt.Name, opt.Env, prefix) + } + delete(excludes, opt.Name) }