opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(coderd): remove the window option in open_in (#16104)

Browse Source 
As we worked on adding a `open_in` parameter for workspace_apps - we
initially created three options :
- window
- slim_window
- tab

After further investigation, `window` should not be used and has to be
removed.

ℹ️ I decided to remove the option instead of deprecating it as we've not
created any release nor documented the feature. Can be discussed.
This commit is contained in:
Vincent Vielle
2025-01-15 15:26:31 +01:00
committed by GitHub
parent b4fde801f5
commit a160e8f06c
12 changed files with 27 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files
coderd/provisionerdserver/provisionerdserver.go
+2 -2
View File
@@ -2017,8 +2017,8 @@ func InsertWorkspaceResource(ctx context.Context, db database.Store, jobID uuid.
switch app.OpenIn {
case sdkproto.AppOpenIn_TAB:
openIn = database.WorkspaceAppOpenInTab
case sdkproto.AppOpenIn_WINDOW:
openIn = database.WorkspaceAppOpenInWindow
case sdkproto.AppOpenIn_SLIM_WINDOW:
openIn = database.WorkspaceAppOpenInSlimWindow
}
dbApp, err := db.InsertWorkspaceApp(ctx, database.InsertWorkspaceAppParams{