Spike/222 workspace build order (#1534)

* chore: refactor before_id/after_id to build_number

Signed-off-by: Spike Curtis <spike@coder.com>

* pagination of workspace_builds

Signed-off-by: Spike Curtis <spike@coder.com>

* Disable parallel on postgres tests

Signed-off-by: Spike Curtis <spike@coder.com>

* Fix lint

Signed-off-by: Spike Curtis <spike@coder.com>

* Fix workspace build postgres query

Signed-off-by: Spike Curtis <spike@coder.com>

* Fix JS tests

Signed-off-by: Spike Curtis <spike@coder.com>

* Fix workspace builds postgres query

Signed-off-by: Spike Curtis <spike@coder.com>

coderd/database/queries/workspacebuilds.sql

@@ -33,27 +33,60 @@ SELECT
 FROM
 	workspace_builds
 WHERE
-	workspace_id = $1;
+	workspace_builds.workspace_id = $1
+    AND CASE
+		-- This allows using the last element on a page as effectively a cursor.
+		-- This is an important option for scripts that need to paginate without
+		-- duplicating or missing data.
+		WHEN @after_id :: uuid != '00000000-00000000-00000000-00000000' THEN (
+			-- The pagination cursor is the last ID of the previous page.
+			-- The query is ordered by the build_number field, so select all
+			-- rows after the cursor.
+			build_number > (
+				SELECT
+					build_number
+				FROM
+					workspace_builds
+				WHERE
+					id = @after_id
+			)
+		)
+		ELSE true
+END
+ORDER BY
+    build_number desc OFFSET @offset_opt
+LIMIT
+    -- A null limit means "no limit", so -1 means return all
+    NULLIF(@limit_opt :: int, -1);
 
--- name: GetWorkspaceBuildByWorkspaceIDWithoutAfter :one
+-- name: GetLatestWorkspaceBuildByWorkspaceID :one
 SELECT
 	*
 FROM
 	workspace_builds
 WHERE
 	workspace_id = $1
-	AND after_id IS NULL
+ORDER BY
+    build_number desc
 LIMIT
 	1;
 
--- name: GetWorkspaceBuildsByWorkspaceIDsWithoutAfter :many
-SELECT
-	*
-FROM
-	workspace_builds
-WHERE
-	workspace_id = ANY(@ids :: uuid [ ])
-	AND after_id IS NULL;
+-- name: GetLatestWorkspaceBuildsByWorkspaceIDs :many
+SELECT wb.*
+FROM (
+    SELECT
+        workspace_id, MAX(build_number) as max_build_number
+    FROM
+        workspace_builds
+    WHERE
+        workspace_id = ANY(@ids :: uuid [ ])
+    GROUP BY
+        workspace_id
+) m
+JOIN
+    workspace_builds wb
+ON m.workspace_id = wb.workspace_id AND m.max_build_number = wb.build_number;
+
 
 -- name: InsertWorkspaceBuild :one
 INSERT INTO
@@ -63,7 +96,7 @@ INSERT INTO
 		updated_at,
 		workspace_id,
 		template_version_id,
-		before_id,
+		"build_number",
 		"name",
 		transition,
 		initiator_id,
@@ -78,7 +111,6 @@ UPDATE
 	workspace_builds
 SET
 	updated_at = $2,
-	after_id = $3,
-	provisioner_state = $4
+	provisioner_state = $3
 WHERE
 	id = $1;