feat(cli): add coder users delete command (#10115)

2026-09-24 15:04:27 +08:00 · 2023-10-09 11:47:57 -05:00
parent 24c80bf532
commit 9e622d00a6
15 changed files with 247 additions and 14 deletions
@@ -0,0 +1,165 @@
+package cli_test
+
+import (
+	"context"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+
+	"github.com/coder/coder/v2/cli/clitest"
+	"github.com/coder/coder/v2/coderd/coderdtest"
+	"github.com/coder/coder/v2/codersdk"
+	"github.com/coder/coder/v2/cryptorand"
+	"github.com/coder/coder/v2/pty/ptytest"
+)
+
+func TestUserDelete(t *testing.T) {
+	t.Parallel()
+	t.Run("Username", func(t *testing.T) {
+		t.Parallel()
+		ctx := context.Background()
+		client := coderdtest.New(t, nil)
+		aUser := coderdtest.CreateFirstUser(t, client)
+
+		pw, err := cryptorand.String(16)
+		require.NoError(t, err)
+
+		_, err = client.CreateUser(ctx, codersdk.CreateUserRequest{
+			Email:          "colin5@coder.com",
+			Username:       "coolin",
+			Password:       pw,
+			UserLoginType:  codersdk.LoginTypePassword,
+			OrganizationID: aUser.OrganizationID,
+			DisableLogin:   false,
+		})
+		require.NoError(t, err)
+
+		inv, root := clitest.New(t, "users", "delete", "coolin")
+		clitest.SetupConfig(t, client, root)
+		pty := ptytest.New(t).Attach(inv)
+		errC := make(chan error)
+		go func() {
+			errC <- inv.Run()
+		}()
+		require.NoError(t, <-errC)
+		pty.ExpectMatch("coolin")
+	})
+
+	t.Run("UserID", func(t *testing.T) {
+		t.Parallel()
+		ctx := context.Background()
+		client := coderdtest.New(t, nil)
+		aUser := coderdtest.CreateFirstUser(t, client)
+
+		pw, err := cryptorand.String(16)
+		require.NoError(t, err)
+
+		user, err := client.CreateUser(ctx, codersdk.CreateUserRequest{
+			Email:          "colin5@coder.com",
+			Username:       "coolin",
+			Password:       pw,
+			UserLoginType:  codersdk.LoginTypePassword,
+			OrganizationID: aUser.OrganizationID,
+			DisableLogin:   false,
+		})
+		require.NoError(t, err)
+
+		inv, root := clitest.New(t, "users", "delete", user.ID.String())
+		clitest.SetupConfig(t, client, root)
+		pty := ptytest.New(t).Attach(inv)
+		errC := make(chan error)
+		go func() {
+			errC <- inv.Run()
+		}()
+		require.NoError(t, <-errC)
+		pty.ExpectMatch("coolin")
+	})
+
+	t.Run("UserID", func(t *testing.T) {
+		t.Parallel()
+		ctx := context.Background()
+		client := coderdtest.New(t, nil)
+		aUser := coderdtest.CreateFirstUser(t, client)
+
+		pw, err := cryptorand.String(16)
+		require.NoError(t, err)
+
+		user, err := client.CreateUser(ctx, codersdk.CreateUserRequest{
+			Email:          "colin5@coder.com",
+			Username:       "coolin",
+			Password:       pw,
+			UserLoginType:  codersdk.LoginTypePassword,
+			OrganizationID: aUser.OrganizationID,
+			DisableLogin:   false,
+		})
+		require.NoError(t, err)
+
+		inv, root := clitest.New(t, "users", "delete", user.ID.String())
+		clitest.SetupConfig(t, client, root)
+		pty := ptytest.New(t).Attach(inv)
+		errC := make(chan error)
+		go func() {
+			errC <- inv.Run()
+		}()
+		require.NoError(t, <-errC)
+		pty.ExpectMatch("coolin")
+	})
+
+	// TODO: reenable this test case. Fetching users without perms returns a
+	// "user "testuser@coder.com" must be a member of at least one organization"
+	// error.
+	// t.Run("NoPerms", func(t *testing.T) {
+	// 	t.Parallel()
+	// 	ctx := context.Background()
+	// 	client := coderdtest.New(t, nil)
+	// 	aUser := coderdtest.CreateFirstUser(t, client)
+
+	// 	pw, err := cryptorand.String(16)
+	// 	require.NoError(t, err)
+
+	// 	fmt.Println(aUser.OrganizationID)
+	// 	toDelete, err := client.CreateUser(ctx, codersdk.CreateUserRequest{
+	// 		Email:          "colin5@coder.com",
+	// 		Username:       "coolin",
+	// 		Password:       pw,
+	// 		UserLoginType:  codersdk.LoginTypePassword,
+	// 		OrganizationID: aUser.OrganizationID,
+	// 		DisableLogin:   false,
+	// 	})
+	// 	require.NoError(t, err)
+
+	// 	uClient, _ := coderdtest.CreateAnotherUser(t, client, aUser.OrganizationID)
+	// 	_ = uClient
+	// 	_ = toDelete
+
+	// 	inv, root := clitest.New(t, "users", "delete", "coolin")
+	// 	clitest.SetupConfig(t, uClient, root)
+	// 	require.ErrorContains(t, inv.Run(), "...")
+	// })
+
+	t.Run("DeleteSelf", func(t *testing.T) {
+		t.Parallel()
+		ctx := context.Background()
+		client := coderdtest.New(t, nil)
+		aUser := coderdtest.CreateFirstUser(t, client)
+
+		pw, err := cryptorand.String(16)
+		require.NoError(t, err)
+
+		_, err = client.CreateUser(ctx, codersdk.CreateUserRequest{
+			Email:          "colin5@coder.com",
+			Username:       "coolin",
+			Password:       pw,
+			UserLoginType:  codersdk.LoginTypePassword,
+			OrganizationID: aUser.OrganizationID,
+			DisableLogin:   false,
+		})
+		require.NoError(t, err)
+
+		coderdtest.CreateAnotherUser(t, client, aUser.OrganizationID)
+
+		inv, root := clitest.New(t, "users", "delete", "me")
+		clitest.SetupConfig(t, client, root)
+		require.ErrorContains(t, inv.Run(), "You cannot delete yourself!")
+	})
+}