From 9bf3b35bbf9dc35b93e4a526e2c5f63f86fb851f Mon Sep 17 00:00:00 2001 From: Michael Smith Date: Wed, 11 Oct 2023 20:23:45 -0400 Subject: [PATCH] fix: update create workspace button to recognize template names+display names (#10233) * fix: only used 'unnamed' as a last resort for templates * fix: update filter logic to read from name field --- site/src/pages/WorkspacesPage/WorkspacesButton.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/site/src/pages/WorkspacesPage/WorkspacesButton.tsx b/site/src/pages/WorkspacesPage/WorkspacesButton.tsx index 550d344e82..c6c238e5df 100644 --- a/site/src/pages/WorkspacesPage/WorkspacesButton.tsx +++ b/site/src/pages/WorkspacesPage/WorkspacesButton.tsx @@ -37,7 +37,11 @@ function sortTemplatesByUsersDesc( const termMatcher = new RegExp(searchTerm.replaceAll(/[^\w]/g, "."), "i"); return templates - .filter((template) => termMatcher.test(template.display_name)) + .filter( + (template) => + termMatcher.test(template.display_name) || + termMatcher.test(template.name), + ) .sort((t1, t2) => t2.active_user_count - t1.active_user_count) .slice(0, 10); } @@ -84,7 +88,7 @@ function WorkspaceResultsRow({ template }: { template: Template }) { sx={{ marginY: 0, paddingBottom: 0.5, lineHeight: 1 }} noWrap > - {template.display_name || "[Unnamed]"} + {template.display_name || template.name || "[Unnamed]"}