From 9afdd33e649ac9d3821c7822b56c1a8d4eae805a Mon Sep 17 00:00:00 2001 From: Cian Johnston Date: Fri, 30 May 2025 16:39:32 +0100 Subject: [PATCH] fix(coderd/database/dbmem): apply rlock/runlock on GetTelemetryItems (#18133) Fixes https://github.com/coder/coder/issues/18132 --- coderd/database/dbmem/dbmem.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go index 69bb3a540e..1eea1d065e 100644 --- a/coderd/database/dbmem/dbmem.go +++ b/coderd/database/dbmem/dbmem.go @@ -5131,7 +5131,9 @@ func (q *FakeQuerier) GetTelemetryItem(_ context.Context, key string) (database. } func (q *FakeQuerier) GetTelemetryItems(_ context.Context) ([]database.TelemetryItem, error) { - return q.telemetryItems, nil + q.mutex.RLock() + defer q.mutex.RUnlock() + return slices.Clone(q.telemetryItems), nil } func (q *FakeQuerier) GetTemplateAppInsights(ctx context.Context, arg database.GetTemplateAppInsightsParams) ([]database.GetTemplateAppInsightsRow, error) {