opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(site): fix disappearing preset selector when switching task template (#20514)

Browse Source 
Closes https://github.com/coder/coder/issues/20465

Ensure we set `selectedPresetId` to `undefined` when we change
`selectedTemplateId` to ensure we don't end up breaking the `<Select>`
component by giving it an invalid preset id.
This commit is contained in:
Danielle Maywood
2025-10-29 21:11:44 +00:00
committed by GitHub
parent 643fe38b1e
commit 9629d873fb
2 changed files with 126 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
site/src/modules/tasks/TaskPrompt/TaskPrompt.stories.tsx
+120
View File
@@ -480,3 +480,123 @@ export const CheckExternalAuthOnChangingVersions: Story = {
});
},
};
export const CheckPresetsWhenChangingTemplate: Story = {
args: {
templates: [
{
...MockTemplate,
id: "claude-code",
name: "claude-code",
display_name: "Claude Code",
active_version_id: "claude-code-version",
},
{
...MockTemplate,
id: "codex",
name: "codex",
display_name: "Codex",
active_version_id: "codex-version",
},
],
},
beforeEach: () => {
spyOn(API, "getTemplateVersionPresets").mockImplementation((versionId) => {
if (versionId === "claude-code-version") {
return Promise.resolve([
{
...MockPresets[0],
ID: "claude-code-preset-1",
Name: "Claude Code Dev",
},
]);
}
if (versionId === "codex-version") {
return Promise.resolve([
{
...MockPresets[0],
ID: "codex-preset-1",
Name: "Codex Dev",
},
]);
}
return Promise.resolve([]);
});
spyOn(API, "getTemplateVersions").mockImplementation((templateId) => {
if (templateId === "claude-code") {
return Promise.resolve([
{
...MockTemplateVersion,
id: "claude-code-version",
name: "claude-code-version",
},
]);
}
if (templateId === "codex") {
return Promise.resolve([
{
...MockTemplateVersion,
id: "codex-version",
name: "codex-version",
},
]);
}
return Promise.resolve([]);
});
},
play: async ({ canvasElement, step }) => {
const canvas = within(canvasElement);
const body = within(canvasElement.ownerDocument.body);
await step("Presets are initially present", async () => {
const presetSelect = await canvas.findByLabelText(/preset/i);
await userEvent.click(presetSelect);
const options = await body.findAllByRole("option");
expect(options).toHaveLength(1);
expect(options[0]).toContainHTML("Claude Code Dev");
await userEvent.click(options[0]);
});
await step("Switch template", async () => {
const templateSelect = await canvas.findByLabelText(/select template/i);
await userEvent.click(templateSelect);
const codexTemplateOption = await body.findByRole("option", {
name: /codex/i,
});
await userEvent.click(codexTemplateOption);
});
await step("Presets are present in new template", async () => {
const presetSelect = await canvas.findByLabelText(/preset/i);
await userEvent.click(presetSelect);
const options = await body.findAllByRole("option");
expect(options).toHaveLength(1);
expect(options[0]).toContainHTML("Codex Dev");
await userEvent.click(options[0]);
});
await step("Switch template back", async () => {
const templateSelect = await canvas.findByLabelText(/select template/i);
await userEvent.click(templateSelect);
const codexTemplateOption = await body.findByRole("option", {
name: /claude code/i,
});
await userEvent.click(codexTemplateOption);
});
await step("Presets are present in original template", async () => {
const presetSelect = await canvas.findByLabelText(/preset/i);
await userEvent.click(presetSelect);
const options = await body.findAllByRole("option");
expect(options).toHaveLength(1);
expect(options[0]).toContainHTML("Claude Code Dev");
});
},
};
site/src/modules/tasks/TaskPrompt/TaskPrompt.tsx
+6 -1
View File
@@ -269,7 +269,12 @@ const CreateTaskForm: FC<CreateTaskFormProps> = ({ templates, onSuccess }) => {
</label>
<Select
name="templateID"
onValueChange={(value) => setSelectedTemplateId(value)}
onValueChange={(value) => {
setSelectedTemplateId(value);
if (value !== selectedTemplateId) {
setSelectedPresetId(undefined);
}
}}
defaultValue={templates[0].id}
required
>