refactor: use sync.WaitGroup.Go in tests (#26671)

Migrate `wg.Add(1); go func() { defer wg.Done(); ... }()` to
`wg.Go(func() { ... })` in tests.

Where the prior pattern passed the loop variable explicitly via a
closure parameter (`go func(id int) { ... }(i)`), drop the parameter and
reference the loop variable directly. Per-iteration loop variables since
Go 1.22 make this safe.
This commit is contained in:
Zach
2026-06-25 15:41:09 -06:00
committed by GitHub
parent b95f2531b5
commit 953091c7bc
24 changed files with 100 additions and 180 deletions
+2 -4
View File
@@ -76,11 +76,9 @@ func TestEnterpriseCreate(t *testing.T) {
createTemplate := func(tplName string, orgID uuid.UUID) {
version := coderdtest.CreateTemplateVersion(t, ownerClient, orgID, nil)
wg.Add(1)
go func() {
wg.Go(func() {
coderdtest.AwaitTemplateVersionJobCompleted(t, ownerClient, version.ID)
wg.Done()
}()
})
coderdtest.CreateTemplate(t, ownerClient, orgID, version.ID, func(request *codersdk.CreateTemplateRequest) {
request.Name = tplName