mirror of
https://github.com/coder/coder.git
synced 2026-09-24 15:04:27 +08:00
refactor: use sync.WaitGroup.Go in tests (#26671)
Migrate `wg.Add(1); go func() { defer wg.Done(); ... }()` to
`wg.Go(func() { ... })` in tests.
Where the prior pattern passed the loop variable explicitly via a
closure parameter (`go func(id int) { ... }(i)`), drop the parameter and
reference the loop variable directly. Per-iteration loop variables since
Go 1.22 make this safe.
This commit is contained in:
@@ -76,11 +76,9 @@ func TestEnterpriseCreate(t *testing.T) {
|
||||
|
||||
createTemplate := func(tplName string, orgID uuid.UUID) {
|
||||
version := coderdtest.CreateTemplateVersion(t, ownerClient, orgID, nil)
|
||||
wg.Add(1)
|
||||
go func() {
|
||||
wg.Go(func() {
|
||||
coderdtest.AwaitTemplateVersionJobCompleted(t, ownerClient, version.ID)
|
||||
wg.Done()
|
||||
}()
|
||||
})
|
||||
|
||||
coderdtest.CreateTemplate(t, ownerClient, orgID, version.ID, func(request *codersdk.CreateTemplateRequest) {
|
||||
request.Name = tplName
|
||||
|
||||
Reference in New Issue
Block a user