From 369af6b04ad72222d058f1e7d837909103735850 Mon Sep 17 00:00:00 2001 From: Presley Date: Mon, 25 Apr 2022 22:51:10 +0000 Subject: [PATCH 1/2] Make detail optional --- site/src/components/FullPageForm/FullPageForm.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/src/components/FullPageForm/FullPageForm.tsx b/site/src/components/FullPageForm/FullPageForm.tsx index dc45c2b923..83f9c345da 100644 --- a/site/src/components/FullPageForm/FullPageForm.tsx +++ b/site/src/components/FullPageForm/FullPageForm.tsx @@ -5,7 +5,7 @@ import { FormTitle } from "../FormTitle/FormTitle" export interface FullPageFormProps { title: string - detail: React.ReactNode + detail?: React.ReactNode onCancel: () => void } From 90283ed6c6de9d543f6c9e44c5874861740f6c17 Mon Sep 17 00:00:00 2001 From: Presley Date: Mon, 25 Apr 2022 22:53:50 +0000 Subject: [PATCH 2/2] Use Language --- site/src/components/FormFooter/FormFooter.tsx | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/site/src/components/FormFooter/FormFooter.tsx b/site/src/components/FormFooter/FormFooter.tsx index 7107f7864b..a7b5c48ba1 100644 --- a/site/src/components/FormFooter/FormFooter.tsx +++ b/site/src/components/FormFooter/FormFooter.tsx @@ -3,6 +3,11 @@ import { makeStyles } from "@material-ui/core/styles" import React from "react" import { LoadingButton } from "../LoadingButton/LoadingButton" +const Language = { + cancelLabel: "Cancel", + defaultSubmitLabel: "Submit", +} + export interface FormFooterProps { onCancel: () => void isLoading: boolean @@ -22,12 +27,16 @@ const useStyles = makeStyles(() => ({ }, })) -export const FormFooter: React.FC = ({ onCancel, isLoading, submitLabel = "Submit" }) => { +export const FormFooter: React.FC = ({ + onCancel, + isLoading, + submitLabel = Language.defaultSubmitLabel, +}) => { const styles = useStyles() return (
{submitLabel}