From 88f0131abbc9c6df646ac74abecf482b167dba58 Mon Sep 17 00:00:00 2001 From: Ethan <39577870+ethanndickson@users.noreply.github.com> Date: Tue, 4 Mar 2025 00:42:13 +1100 Subject: [PATCH] fix: use dbtime in dbmem query to fix flake (#16773) Closes https://github.com/coder/internal/issues/447. The test was failing 30% of the time on Windows without the rounding applied by `dbtime`. `dbtime` was used on the timestamps inserted into the DB, but not within the query. Once using `dbtime` within the query there were no failures in 200 runs. --- coderd/database/dbmem/dbmem.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go index 65d24bb343..cc559a7e77 100644 --- a/coderd/database/dbmem/dbmem.go +++ b/coderd/database/dbmem/dbmem.go @@ -7014,7 +7014,7 @@ func (q *FakeQuerier) GetWorkspaceAgentUsageStatsAndLabels(_ context.Context, cr } // WHERE usage = true AND created_at > now() - '1 minute'::interval // GROUP BY user_id, agent_id, workspace_id - if agentStat.Usage && agentStat.CreatedAt.After(time.Now().Add(-time.Minute)) { + if agentStat.Usage && agentStat.CreatedAt.After(dbtime.Now().Add(-time.Minute)) { val, ok := latestAgentStats[key] if !ok { latestAgentStats[key] = agentStat