opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(pty): close output writer before reader on Windows to unblock close (#8299)

Browse Source
This commit is contained in:
Mathias Fredriksson
2023-07-05 15:25:07 +03:00
committed by GitHub
parent 59246e054f
commit 88c35d3f04
2 changed files with 75 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pty/ptytest/ptytest.go
+14 -2
View File
@@ -354,7 +354,13 @@ type PTY struct {
func (p *PTY) Close() error {
p.t.Helper()
pErr := p.PTY.Close()
eErr := p.outExpecter.close("close")
if pErr != nil {
p.logf("PTY: Close failed: %v", pErr)
}
eErr := p.outExpecter.close("PTY close")
if eErr != nil {
p.logf("PTY: close expecter failed: %v", eErr)
}
if pErr != nil {
return pErr
}
@@ -398,7 +404,13 @@ type PTYCmd struct {
func (p *PTYCmd) Close() error {
p.t.Helper()
pErr := p.PTYCmd.Close()
eErr := p.outExpecter.close("close")
if pErr != nil {
p.logf("PTYCmd: Close failed: %v", pErr)
}
eErr := p.outExpecter.close("PTYCmd close")
if eErr != nil {
p.logf("PTYCmd: close expecter failed: %v", eErr)
}
if pErr != nil {
return pErr
}