From 86d8b6daeef565eda731ec742fb2abf72683705e Mon Sep 17 00:00:00 2001 From: Danielle Maywood Date: Mon, 23 Mar 2026 17:22:08 +0000 Subject: [PATCH] fix(site/src/pages/AgentsPage): add collapse button to settings sidebar panel (#23438) --- .../AgentsPage/AgentsPageView.stories.tsx | 7 +++- .../components/Sidebar/AgentsSidebar.tsx | 41 +++++++++++++++---- 2 files changed, 37 insertions(+), 11 deletions(-) diff --git a/site/src/pages/AgentsPage/AgentsPageView.stories.tsx b/site/src/pages/AgentsPage/AgentsPageView.stories.tsx index de646c40f2..56019b5de1 100644 --- a/site/src/pages/AgentsPage/AgentsPageView.stories.tsx +++ b/site/src/pages/AgentsPage/AgentsPageView.stories.tsx @@ -493,7 +493,10 @@ const openAnalyticsView = async (canvasElement: HTMLElement) => { const openSettingsView = async (canvasElement: HTMLElement) => { const canvas = within(canvasElement); - await userEvent.click(canvas.getByRole("link", { name: "Settings" })); + const link = await waitFor(() => + canvas.getByRole("link", { name: "Settings" }), + ); + await userEvent.click(link); }; export const OpensAnalyticsForAdmins: Story = { @@ -597,7 +600,7 @@ export const SettingsViewResets: Story = { }); // Go back to chats - const backButton = screen.getByLabelText("Back to chats from Settings"); + const backButton = screen.getByLabelText("Back to chats"); await userEvent.click(backButton); // Re-open settings, should reset to Behavior diff --git a/site/src/pages/AgentsPage/components/Sidebar/AgentsSidebar.tsx b/site/src/pages/AgentsPage/components/Sidebar/AgentsSidebar.tsx index 3a99a8e196..2ea4d48ac5 100644 --- a/site/src/pages/AgentsPage/components/Sidebar/AgentsSidebar.tsx +++ b/site/src/pages/AgentsPage/components/Sidebar/AgentsSidebar.tsx @@ -930,15 +930,38 @@ export const AgentsSidebar: FC = (props) => { inert={sidebarView.panel !== "settings" ? true : undefined} > {/* Back header */} -
- - - {subNavTitle} - +
+
+ + + {subNavTitle} + +
+ {onCollapse && ( + + )} +
+
{/* Sub-navigation items */} {sidebarView.panel === "settings" && (