From 854ef5b07cb1da9b4339008fb6e5775c16ee62fb Mon Sep 17 00:00:00 2001
From: Jaayden Halko <jaayden.halko@gmail.com>
Date: Fri, 30 May 2025 16:13:16 -0500
Subject: [PATCH] fix: improve create workspace page for dynamic parameters
 (#18139)

- Avoid scrolling on workspace creation
- hide auth required badge when authenticated
---
 .../CreateWorkspacePageViewExperimental.tsx               | 2 +-
 site/src/pages/CreateWorkspacePage/ExternalAuthButton.tsx | 8 ++++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
index 55b507e219..09056aa66a 100644
--- a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
+++ b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
@@ -179,7 +179,7 @@ export const CreateWorkspacePageViewExperimental: FC<
 	}, [error]);
 
 	useEffect(() => {
-		if (form.submitCount > 0 && form.errors) {
+		if (form.submitCount > 0 && Object.keys(form.errors).length > 0) {
 			workspaceNameInputRef.current?.scrollIntoView({
 				behavior: "smooth",
 				block: "center",
diff --git a/site/src/pages/CreateWorkspacePage/ExternalAuthButton.tsx b/site/src/pages/CreateWorkspacePage/ExternalAuthButton.tsx
index 5ce8cf4c3d..65e2de6dce 100644
--- a/site/src/pages/CreateWorkspacePage/ExternalAuthButton.tsx
+++ b/site/src/pages/CreateWorkspacePage/ExternalAuthButton.tsx
@@ -38,8 +38,12 @@ export const ExternalAuthButton: FC<ExternalAuthButtonProps> = ({
 					/>
 				)}
 				<p className="font-semibold text-sm m-0">{auth.display_name}</p>
-				{!auth.optional && (
-					<Badge size="sm" variant={error ? "destructive" : "warning"}>
+				{!auth.authenticated && !auth.optional && (
+					<Badge
+						size="sm"
+						border="none"
+						variant={error ? "destructive" : "warning"}
+					>
 						Required
 					</Badge>
 				)}