From 85289464b6e17652e7b523d74934384abdc69bf9 Mon Sep 17 00:00:00 2001 From: Cian Johnston Date: Tue, 19 May 2026 10:35:50 +0100 Subject: [PATCH] fix(cli): remove unnecessary PTY from TestServerCreateAdminUser/Validates (#25444) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes https://linear.app/codercom/issue/PLAT-224 The Validates subtest only checks that `Run()` returns a validation error and never reads PTY output. We don't need it in this test, so removing. > 🤖 Generated by Coder Agents --- cli/server_createadminuser_test.go | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/cli/server_createadminuser_test.go b/cli/server_createadminuser_test.go index 7660d71e89..c0883a2d27 100644 --- a/cli/server_createadminuser_test.go +++ b/cli/server_createadminuser_test.go @@ -4,6 +4,7 @@ import ( "context" "database/sql" "fmt" + "io" "runtime" "testing" @@ -224,8 +225,7 @@ func TestServerCreateAdminUser(t *testing.T) { } connectionURL, err := dbtestutil.Open(t) require.NoError(t, err) - ctx, cancelFunc := context.WithCancel(context.Background()) - defer cancelFunc() + ctx := testutil.Context(t, testutil.WaitShort) root, _ := clitest.New(t, "server", "create-admin-user", @@ -235,10 +235,7 @@ func TestServerCreateAdminUser(t *testing.T) { "--email", "not-an-email", "--password", "x", ) - pty := ptytest.New(t) - root.Stdout = pty.Output() - root.Stderr = pty.Output() - + root.Stdout, root.Stderr = io.Discard, io.Discard err = root.WithContext(ctx).Run() require.Error(t, err) require.ErrorContains(t, err, "'email' failed on the 'email' tag")