fix: preserve workspace resource metadata order (#5421)

Fixes #4511.

site/src/components/Resources/ResourceCard.stories.tsx

@@ -31,7 +31,6 @@ BunchOfMetadata.args = {
   resource: {
     ...MockWorkspaceResource,
     metadata: [
-      { key: "type", value: "kubernetes_pod", sensitive: false },
       {
         key: "CPU(limits, requests)",
         value: "2 cores, 500m",

site/src/components/Resources/ResourceCard.tsx

@@ -22,9 +22,7 @@ export const ResourceCard: FC<ResourceCardProps> = ({ resource, agentRow }) => {
   const [shouldDisplayAllMetadata, setShouldDisplayAllMetadata] =
     useState(false)
   const styles = useStyles()
-  const metadataToDisplay =
-    // Type is already displayed in the header
-    resource.metadata?.filter((data) => data.key !== "type") ?? []
+  const metadataToDisplay = resource.metadata ?? []
   const visibleMetadata = shouldDisplayAllMetadata
     ? metadataToDisplay
     : metadataToDisplay.slice(0, 4)

site/src/testHelpers/entities.ts

@@ -338,10 +338,7 @@ export const MockWorkspaceResource: TypesGen.WorkspaceResource = {
   workspace_transition: "start",
   hide: false,
   icon: "",
-  metadata: [
-    { key: "type", value: "a-workspace-resource", sensitive: false },
-    { key: "api_key", value: "12345678", sensitive: true },
-  ],
+  metadata: [{ key: "api_key", value: "12345678", sensitive: true }],
   daily_cost: 10,
 }
 
@@ -359,10 +356,7 @@ export const MockWorkspaceResource2: TypesGen.WorkspaceResource = {
   workspace_transition: "start",
   hide: false,
   icon: "",
-  metadata: [
-    { key: "type", value: "google_compute_disk", sensitive: false },
-    { key: "size", value: "32GB", sensitive: false },
-  ],
+  metadata: [{ key: "size", value: "32GB", sensitive: false }],
   daily_cost: 10,
 }
 
@@ -380,10 +374,7 @@ export const MockWorkspaceResource3: TypesGen.WorkspaceResource = {
   workspace_transition: "start",
   hide: true,
   icon: "",
-  metadata: [
-    { key: "type", value: "google_compute_disk", sensitive: false },
-    { key: "size", value: "32GB", sensitive: false },
-  ],
+  metadata: [{ key: "size", value: "32GB", sensitive: false }],
   daily_cost: 20,
 }