From 84881a0e981354828ce7bf2779ac4a0fd95d8664 Mon Sep 17 00:00:00 2001 From: Yevhenii Shcherbina Date: Tue, 4 Mar 2025 08:44:48 -0500 Subject: [PATCH] test: fix flaky tests (#16799) Relates to: https://github.com/coder/internal/issues/451 Create separate context with timeout for every subtest. --- coderd/database/querier_test.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/coderd/database/querier_test.go b/coderd/database/querier_test.go index ecf9a59c0a..2eb3125fc2 100644 --- a/coderd/database/querier_test.go +++ b/coderd/database/querier_test.go @@ -2169,9 +2169,6 @@ func TestExpectOne(t *testing.T) { func TestGetProvisionerJobsByIDsWithQueuePosition(t *testing.T) { t.Parallel() - now := dbtime.Now() - ctx := testutil.Context(t, testutil.WaitShort) - testCases := []struct { name string jobTags []database.StringMap @@ -2393,6 +2390,8 @@ func TestGetProvisionerJobsByIDsWithQueuePosition(t *testing.T) { t.Run(tc.name, func(t *testing.T) { t.Parallel() db, _ := dbtestutil.NewDB(t) + now := dbtime.Now() + ctx := testutil.Context(t, testutil.WaitShort) // Create provisioner jobs based on provided tags: allJobs := make([]database.ProvisionerJob, len(tc.jobTags))