fix(coderd): disable chat worker in TestPostChatMessagesBusyInterrupt (#26331)

Addresses https://github.com/coder/internal/issues/1584
This commit is contained in:
Hugo Dutka
2026-06-12 14:47:34 +02:00
committed by GitHub
parent 79a28bad72
commit 84843e619a
3 changed files with 19 additions and 7 deletions
+7 -1
View File
@@ -258,6 +258,9 @@ type Options struct {
// ChatProviderAPIKeys overrides deployment-derived provider keys.
// Test harnesses use this to route chat models to local providers.
ChatProviderAPIKeys *chatprovider.ProviderAPIKeys
// ChatWorkerDisabled skips starting the chat daemon's background
// worker.
ChatWorkerDisabled bool
UpdateAgentMetrics func(ctx context.Context, labels prometheusmetrics.AgentMetricLabels, metrics []*agentproto.Stats_Metric)
StatsBatcher workspacestats.Batcher
@@ -839,7 +842,10 @@ func New(options *Options) *API {
OIDCTokenSource: oidcMCPSrc,
NotificationsEnqueuer: options.NotificationsEnqueuer,
Auditor: &api.Auditor,
}).Start()
})
if !options.ChatWorkerDisabled {
api.chatDaemon.Start()
}
gitSyncLogger := options.Logger.Named("gitsync")
refresher := gitsync.NewRefresher(
api.resolveGitProvider,
+9 -5
View File
@@ -154,11 +154,14 @@ type Options struct {
IncludeProvisionerDaemon bool
ChatdInstructionLookupTimeout time.Duration
ChatProviderAPIKeys *chatprovider.ProviderAPIKeys
ProvisionerDaemonVersion string
ProvisionerDaemonTags map[string]string
MetricsCacheRefreshInterval time.Duration
AgentStatsRefreshInterval time.Duration
DeploymentValues *codersdk.DeploymentValues
// ChatWorkerDisabled skips starting the chat daemon's background
// worker. Used in tests.
ChatWorkerDisabled bool
ProvisionerDaemonVersion string
ProvisionerDaemonTags map[string]string
MetricsCacheRefreshInterval time.Duration
AgentStatsRefreshInterval time.Duration
DeploymentValues *codersdk.DeploymentValues
// Set update check options to enable update check.
UpdateCheckOptions *updatecheck.Options
@@ -594,6 +597,7 @@ func NewOptions(t testing.TB, options *Options) (func(http.Handler), context.Can
AgentInactiveDisconnectTimeout: testutil.WaitShort,
ChatdInstructionLookupTimeout: options.ChatdInstructionLookupTimeout,
ChatProviderAPIKeys: options.ChatProviderAPIKeys,
ChatWorkerDisabled: options.ChatWorkerDisabled,
AccessURL: accessURL,
AppHostname: options.AppHostname,
AppHostnameRegex: appHostnameRegex,
+3 -1
View File
@@ -172,7 +172,9 @@ func TestPostChatMessagesBusyInterrupt(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitLong)
client := newChatClient(t)
client := newChatClient(t, func(o *coderdtest.Options) {
o.ChatWorkerDisabled = true
})
firstUser := coderdtest.CreateFirstUser(t, client.Client)
_ = createChatModelConfig(t, client)