From 7bc98c296bd6b8fc5e1bb203a95ac87e07c639bc Mon Sep 17 00:00:00 2001
From: Bruno Quaresma <bruno@coder.com>
Date: Tue, 19 Sep 2023 09:54:59 -0300
Subject: [PATCH] refactor(site): do not display error details as message
 (#9755)

---
 site/src/api/errors.ts                             | 7 +------
 site/src/pages/LoginPage/LoginPageView.stories.tsx | 9 +++++----
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/site/src/api/errors.ts b/site/src/api/errors.ts
index f8d9421631..ea8b1d0c4c 100644
--- a/site/src/api/errors.ts
+++ b/site/src/api/errors.ts
@@ -61,12 +61,7 @@ export const mapApiErrorToFieldErrors = (
 export const getErrorMessage = (
   error: unknown,
   defaultMessage: string,
-): string =>
-  isApiError(error)
-    ? error.response.data.message
-    : error instanceof Error
-    ? error.message
-    : defaultMessage;
+): string => (isApiError(error) ? error.response.data.message : defaultMessage);
 
 /**
  *
diff --git a/site/src/pages/LoginPage/LoginPageView.stories.tsx b/site/src/pages/LoginPage/LoginPageView.stories.tsx
index a28baadd95..a4420489c5 100644
--- a/site/src/pages/LoginPage/LoginPageView.stories.tsx
+++ b/site/src/pages/LoginPage/LoginPageView.stories.tsx
@@ -1,5 +1,5 @@
 import { action } from "@storybook/addon-actions";
-import { MockAuthMethods } from "testHelpers/entities";
+import { MockAuthMethods, mockApiError } from "testHelpers/entities";
 import { LoginPageView } from "./LoginPageView";
 import type { Meta, StoryObj } from "@storybook/react";
 
@@ -24,14 +24,15 @@ export const Example: Story = {
   },
 };
 
-const err = new Error("Username or email are wrong.");
-
 export const AuthError: Story = {
   args: {
     isLoading: false,
     onSignIn: action("onSignIn"),
     context: {
-      error: err,
+      error: mockApiError({
+        message: "User or password is incorrect",
+        detail: "Please, try again",
+      }),
       data: {
         authMethods: MockAuthMethods,
         hasFirstUser: false,