From 76d6e13185b2acd8d0fd23e43e0d9c3eb8bcccc0 Mon Sep 17 00:00:00 2001 From: Ethan <39577870+ethanndickson@users.noreply.github.com> Date: Thu, 2 Oct 2025 11:22:05 +1000 Subject: [PATCH] ci: make `changes` required (#20131) Earlier today, a dependabot PR was merged despite CI not having been run. https://github.com/coder/coder/pull/20068 This was because the `changes` job failed due to a github ratelimit, which caused all the tests to be skipped, which caused `required` to pass as it passes if tests are skipped. image This PR makes `changes` required so this can't happen again (assuming we keep around the dependabot automerge around, it might). --- .github/workflows/ci.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 2d41883287..6fbba7883a 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -919,6 +919,7 @@ jobs: required: runs-on: ubuntu-latest needs: + - changes - fmt - lint - gen @@ -942,6 +943,7 @@ jobs: - name: Ensure required checks run: | # zizmor: ignore[template-injection] We're just reading needs.x.result here, no risk of injection echo "Checking required checks" + echo "- changes: ${{ needs.changes.result }}" echo "- fmt: ${{ needs.fmt.result }}" echo "- lint: ${{ needs.lint.result }}" echo "- gen: ${{ needs.gen.result }}"