From 76a2cb1af5c775d2e2045912e3665cd951bcc724 Mon Sep 17 00:00:00 2001 From: Ethan <39577870+ethanndickson@users.noreply.github.com> Date: Wed, 8 Apr 2026 00:32:36 +1000 Subject: [PATCH] fix(site/src/pages/AgentsPage): reset provider form after create (#23975) Previously, after creating a provider config in the agents provider editor, the Save changes button stayed enabled for the lifetime of the mounted form. The form kept the pre-create local baseline, so the freshly-saved values still looked dirty. Key `ProviderForm` by provider config identity so React remounts the form when a config is created and re-establishes the pristine state from the saved provider values. --- .../ChatModelAdminPanel/ChatModelAdminPanel.stories.tsx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ChatModelAdminPanel.stories.tsx b/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ChatModelAdminPanel.stories.tsx index 3d33f035c5..1114ac2f41 100644 --- a/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ChatModelAdminPanel.stories.tsx +++ b/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ChatModelAdminPanel.stories.tsx @@ -462,6 +462,9 @@ export const CreateAndUpdateProvider: Story = { await waitFor(() => { expect(args.onCreateProvider).toHaveBeenCalledTimes(1); }); + await waitFor(() => { + expect(body.getByRole("button", { name: "Save changes" })).toBeDisabled(); + }); expect(args.onCreateProvider).toHaveBeenCalledWith( expect.objectContaining({ provider: "openai",