From 74fb2aaf085c8ba7d499cf0e90c2c544e7454aec Mon Sep 17 00:00:00 2001 From: Kacper Sawicki Date: Thu, 28 Aug 2025 10:24:43 +0200 Subject: [PATCH] fix: fix flake in TestPatchCancelWorkspaceBuild/User_is_allowed_to_cancel (#19522) Fixes: https://github.com/coder/internal/issues/885 --- coderd/workspacebuilds_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/coderd/workspacebuilds_test.go b/coderd/workspacebuilds_test.go index e888115093..994411a8b3 100644 --- a/coderd/workspacebuilds_test.go +++ b/coderd/workspacebuilds_test.go @@ -577,8 +577,12 @@ func TestPatchCancelWorkspaceBuild(t *testing.T) { build, err = client.WorkspaceBuild(ctx, workspace.LatestBuild.ID) return assert.NoError(t, err) && build.Job.Status == codersdk.ProvisionerJobRunning }, testutil.WaitShort, testutil.IntervalFast) - err := client.CancelWorkspaceBuild(ctx, build.ID, codersdk.CancelWorkspaceBuildParams{}) - require.NoError(t, err) + + require.Eventually(t, func() bool { + err := client.CancelWorkspaceBuild(ctx, build.ID, codersdk.CancelWorkspaceBuildParams{}) + return assert.NoError(t, err) + }, testutil.WaitShort, testutil.IntervalMedium) + require.Eventually(t, func() bool { var err error build, err = client.WorkspaceBuild(ctx, build.ID)