fix(agent/agentcontainer): allow lifecycle script error on devcontainer up (#21020)

Browse Source

When devcontainer up fails due to a lifecycle script error like
postCreateCommand, the CLI still returns a container ID. Previously
this was discarded and the devcontainer marked as failed. Now we
continue with agent injection if a container ID is available,
allowing users to debug the issue in the running container.

Fixes coder/internal#1137

...

This commit is contained in:

Mathias Fredriksson

2025-12-02 15:33:01 +02:00

committed by GitHub

parent bf40d678ec

commit 74d0c39cb3

5 changed files with 381 additions and 75 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

agent/agentcontainers/testdata/devcontainercli/parse/up-error-lifecycle-script.log

Generated Vendored

+147

File diff suppressed because one or more lines are too long