From 73402fc2f765424339d19b074ebb8c8c0f975e4d Mon Sep 17 00:00:00 2001 From: Ethan <39577870+ethanndickson@users.noreply.github.com> Date: Mon, 12 Aug 2024 18:56:34 +1000 Subject: [PATCH] fix: fix flaking `Test_sshConfigExecEscape` (#14233) Fixes #13962. --- cli/configssh_internal_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cli/configssh_internal_test.go b/cli/configssh_internal_test.go index 16c950af0f..d3eee395de 100644 --- a/cli/configssh_internal_test.go +++ b/cli/configssh_internal_test.go @@ -138,6 +138,7 @@ func Test_sshConfigSplitOnCoderSection(t *testing.T) { // This test tries to mimic the behavior of OpenSSH // when executing e.g. a ProxyCommand. +// nolint:tparallel func Test_sshConfigExecEscape(t *testing.T) { t.Parallel() @@ -154,11 +155,10 @@ func Test_sshConfigExecEscape(t *testing.T) { {"tabs", "path with \ttabs", false}, {"newline fails", "path with \nnewline", true}, } + // nolint:paralleltest // Fixes a flake for _, tt := range tests { tt := tt t.Run(tt.name, func(t *testing.T) { - t.Parallel() - if runtime.GOOS == "windows" { t.Skip("Windows doesn't typically execute via /bin/sh or cmd.exe, so this test is not applicable.") }