From 70b093ff2a64b759d96938163037c6c9eaae7a94 Mon Sep 17 00:00:00 2001 From: Kyle Carberry Date: Thu, 9 Mar 2023 09:08:41 -0600 Subject: [PATCH] fix: filter session count sums by `created_at` (#6529) Fixes the session totals being waaaaay too high! --- coderd/database/queries.sql.go | 2 +- coderd/database/queries/workspaceagentstats.sql | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go index afda32650f..707e87ee6f 100644 --- a/coderd/database/queries.sql.go +++ b/coderd/database/queries.sql.go @@ -5562,7 +5562,7 @@ WITH agent_stats AS ( coalesce(SUM(session_count_reconnecting_pty), 0)::bigint AS session_count_reconnecting_pty FROM ( SELECT id, created_at, user_id, agent_id, workspace_id, template_id, connections_by_proto, connection_count, rx_packets, rx_bytes, tx_packets, tx_bytes, connection_median_latency_ms, session_count_vscode, session_count_jetbrains, session_count_reconnecting_pty, session_count_ssh, ROW_NUMBER() OVER(PARTITION BY agent_id ORDER BY created_at DESC) AS rn - FROM workspace_agent_stats + FROM workspace_agent_stats WHERE created_at > $1 ) AS a WHERE a.rn = 1 ) SELECT workspace_rx_bytes, workspace_tx_bytes, workspace_connection_latency_50, workspace_connection_latency_95, session_count_vscode, session_count_ssh, session_count_jetbrains, session_count_reconnecting_pty FROM agent_stats, latest_agent_stats diff --git a/coderd/database/queries/workspaceagentstats.sql b/coderd/database/queries/workspaceagentstats.sql index 176dcec96d..6579b04c51 100644 --- a/coderd/database/queries/workspaceagentstats.sql +++ b/coderd/database/queries/workspaceagentstats.sql @@ -70,7 +70,7 @@ WITH agent_stats AS ( coalesce(SUM(session_count_reconnecting_pty), 0)::bigint AS session_count_reconnecting_pty FROM ( SELECT *, ROW_NUMBER() OVER(PARTITION BY agent_id ORDER BY created_at DESC) AS rn - FROM workspace_agent_stats + FROM workspace_agent_stats WHERE created_at > $1 ) AS a WHERE a.rn = 1 ) SELECT * FROM agent_stats, latest_agent_stats;