fix: allow group members to read group information (#14200)

* - allow group members to read basic Group info
- allow group members to see they are part of the group, but not see that information about other members
- add a GetGroupMembersCountByGroupID SQL query, which allows group members to see members count without revealing other information about the members
- add the group_members_expanded db view
- rewrite group member queries to use the group_members_expanded view
- add the RBAC ResourceGroupMember and add it to relevant roles
- rewrite GetGroupMembersByGroupID permission checks
- make the GroupMember type contain all user fields
- fix type issues coming from replacing User with GroupMember in group member queries
- add the MemberTotalCount field to codersdk.Group
- display `group.total_member_count` instead of `group.members.length` on the account page

coderd/telemetry/telemetry_test.go

@@ -49,14 +49,14 @@ func TestTelemetry(t *testing.T) {
 			Provisioner: database.ProvisionerTypeTerraform,
 		})
 		_ = dbgen.TemplateVersion(t, db, database.TemplateVersion{})
-		_ = dbgen.User(t, db, database.User{})
+		user := dbgen.User(t, db, database.User{})
 		_ = dbgen.Workspace(t, db, database.Workspace{})
 		_ = dbgen.WorkspaceApp(t, db, database.WorkspaceApp{
 			SharingLevel: database.AppSharingLevelOwner,
 			Health:       database.WorkspaceAppHealthDisabled,
 		})
-		_ = dbgen.Group(t, db, database.Group{})
-		_ = dbgen.GroupMember(t, db, database.GroupMember{})
+		group := dbgen.Group(t, db, database.Group{})
+		_ = dbgen.GroupMember(t, db, database.GroupMemberTable{UserID: user.ID, GroupID: group.ID})
 		wsagent := dbgen.WorkspaceAgent(t, db, database.WorkspaceAgent{})
 		// Update the workspace agent to have a valid subsystem.
 		err = db.UpdateWorkspaceAgentStartupByID(ctx, database.UpdateWorkspaceAgentStartupByIDParams{
@@ -94,7 +94,8 @@ func TestTelemetry(t *testing.T) {
 		require.Len(t, snapshot.TemplateVersions, 1)
 		require.Len(t, snapshot.Users, 1)
 		require.Len(t, snapshot.Groups, 2)
-		require.Len(t, snapshot.GroupMembers, 1)
+		// 1 member in the everyone group + 1 member in the custom group
+		require.Len(t, snapshot.GroupMembers, 2)
 		require.Len(t, snapshot.Workspaces, 1)
 		require.Len(t, snapshot.WorkspaceApps, 1)
 		require.Len(t, snapshot.WorkspaceAgents, 1)