From 6ee5fe983c0a5c100183800e22a5c506d4be9764 Mon Sep 17 00:00:00 2001
From: 35C4n0r <70096901+35C4n0r@users.noreply.github.com>
Date: Fri, 1 May 2026 16:10:53 +0530
Subject: [PATCH] fix(site/src/pages/TemplateVersionEditorPage): make Create
 Workspace button a link (#24803)

The "Create a workspace" button in the template publish success banner
used an `onClick` handler with `navigate()`, rendering a plain
`<button>`. Users could not right-click to open in a new tab.

Changed the prop from `onCreateWorkspace` callback to
`createWorkspaceUrl` string and switched to `<Button asChild>` +
`<RouterLink>`, rendering a proper `<a>` element that supports standard
link interactions (right-click, middle-click, Ctrl+click).

Fixes https://github.com/coder/coder/issues/24802

> _This PR was authored by Coder Agents on behalf of @35C4n0r._
---
 .../TemplateVersionEditor.stories.tsx                |  2 +-
 .../TemplateVersionEditor.tsx                        | 10 ++++++----
 .../TemplateVersionEditorPage.tsx                    | 12 +++++-------
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.stories.tsx b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.stories.tsx
index a4f2f15ee6..b4a553e4ec 100644
--- a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.stories.tsx
+++ b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.stories.tsx
@@ -35,7 +35,7 @@ const meta: Meta<typeof TemplateVersionEditor> = {
 		onPublish: action("onPublish"),
 		onConfirmPublish: action("onConfirmPublish"),
 		onCancelPublish: action("onCancelPublish"),
-		onCreateWorkspace: action("onCreateWorkspace"),
+		createWorkspaceUrl: "/templates/default/test-template/workspace",
 		onSubmitMissingVariableValues: action("onSubmitMissingVariableValues"),
 		onCancelSubmitMissingVariableValues: action(
 			"onCancelSubmitMissingVariableValues",
diff --git a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx
index 5393f496e3..29e8767b3e 100644
--- a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx
+++ b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx
@@ -89,7 +89,7 @@ interface TemplateVersionEditorProps {
 	onCancelPublish: () => void;
 	publishingError?: unknown;
 	publishedVersion?: TemplateVersion;
-	onCreateWorkspace: () => void;
+	createWorkspaceUrl: string | undefined;
 	isAskingPublishParameters: boolean;
 	isPromptingMissingVariables: boolean;
 	isPublishing: boolean;
@@ -117,7 +117,7 @@ export const TemplateVersionEditor: FC<TemplateVersionEditorProps> = ({
 	isPublishing,
 	publishingError,
 	publishedVersion,
-	onCreateWorkspace,
+	createWorkspaceUrl,
 	buildLogs,
 	resources,
 	isPromptingMissingVariables,
@@ -307,8 +307,10 @@ export const TemplateVersionEditor: FC<TemplateVersionEditorProps> = ({
 								prominent
 								dismissible
 								actions={
-									<Button size="sm" onClick={onCreateWorkspace}>
-										Create a workspace
+									<Button asChild size="sm">
+										<RouterLink to={createWorkspaceUrl ?? ""}>
+											Create a workspace
+										</RouterLink>
 									</Button>
 								}
 							>
diff --git a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.tsx b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.tsx
index 2f52826332..d46f06b7ba 100644
--- a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.tsx
+++ b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.tsx
@@ -187,18 +187,16 @@ const TemplateVersionEditorPage: FC = () => {
 					isPublishing={publishVersionMutation.isPending}
 					publishingError={publishVersionMutation.error}
 					publishedVersion={lastSuccessfulPublishedVersion}
-					onCreateWorkspace={() => {
+					createWorkspaceUrl={(() => {
 						const params = new URLSearchParams();
 						const publishedVersion = lastSuccessfulPublishedVersion;
 						if (publishedVersion) {
 							params.set("version", publishedVersion.id);
 						}
-						navigate(
-							`${getLink(
-								linkToTemplate(organizationName, templateName),
-							)}/workspace?${params.toString()}`,
-						);
-					}}
+						return `${getLink(
+							linkToTemplate(organizationName, templateName),
+						)}/workspace?${params.toString()}`;
+					})()}
 					isBuilding={
 						createTemplateVersionMutation.isPending ||
 						uploadFileMutation.isPending ||