From 6b3f5994381f2806f52da5a71ecee605b5059833 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Mon, 20 Nov 2023 19:30:09 +0200 Subject: [PATCH] fix(site): correctly interpret timezone based on offset in `formatOffset` (#10797) Fixes #10784 --- .../TemplateInsightsPage/TemplateInsightsPage.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsightsPage.tsx b/site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsightsPage.tsx index c875bbd576..f5f6c4ca38 100644 --- a/site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsightsPage.tsx +++ b/site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsightsPage.tsx @@ -791,14 +791,14 @@ function toISOLocal(d: Date, offset: number) { } function formatOffset(offset: number): string { - const isPositive = offset >= 0; + // A negative offset means that this is a positive timezone, e.g. GMT+2 = -120. + const isPositiveTimezone = offset <= 0; const absoluteOffset = Math.abs(offset); const hours = Math.floor(absoluteOffset / 60); const minutes = Math.abs(offset) % 60; - const formattedHours = `${isPositive ? "+" : "-"}${String(hours).padStart( - 2, - "0", - )}`; + const formattedHours = `${isPositiveTimezone ? "+" : "-"}${String( + hours, + ).padStart(2, "0")}`; const formattedMinutes = String(minutes).padStart(2, "0"); return `${formattedHours}:${formattedMinutes}`; }