chore: tighten .vscode IDE and typescript configuration (#24537)

This branch tightens import hygiene and editor guidance to reduce
accidental use of legacy or discouraged patterns.
It also updates consumers too, by propagating the new `lucide-react`
import convention across the existing UI surfaces that reference those
icons.

- Updated `.vscode/settings.json` to prefer non-relative imports and
improve TypeScript auto-import behavior.
- Re-enabled and expanded Biome restricted-import enforcement in
`biome.jsonc` for migration guardrails.
- Added/used `lucide-react` `-Icon` naming conventions for clarity and
consistency.
- Updated consumers too across components, modules, and pages so the new
import rules are applied end-to-end.
This commit is contained in:
Jake Howell
2026-04-21 13:45:08 +10:00
committed by GitHub
parent e186dc3222
commit 67c57abb63
63 changed files with 218 additions and 183 deletions
@@ -1,4 +1,4 @@
import { Check } from "lucide-react";
import { CheckIcon } from "lucide-react";
import { type FC, useState } from "react";
import { keepPreviousData, useQuery } from "react-query";
import { groupsByOrganization } from "#/api/queries/groups";
@@ -122,7 +122,7 @@ export const UserOrGroupAutocomplete: FC<UserOrGroupAutocompleteProps> = ({
subtitle={isGroup(option) ? getGroupSubtitle(option) : option.email}
src={option.avatar_url}
/>
{isSelected && <Check className="size-4 shrink-0" />}
{isSelected && <CheckIcon className="size-4 shrink-0" />}
</div>
)}
open={open}
@@ -1,4 +1,4 @@
import { EllipsisVertical, UserPlusIcon } from "lucide-react";
import { EllipsisVerticalIcon, UserPlusIcon } from "lucide-react";
import type { FC, ReactNode } from "react";
import { useQuery } from "react-query";
import { workspaceSharingSettings } from "#/api/queries/organizations";
@@ -279,7 +279,7 @@ export const WorkspaceSharingForm: FC<WorkspaceSharingFormProps> = ({
variant="subtle"
aria-label="Open menu"
>
<EllipsisVertical aria-hidden="true" />
<EllipsisVerticalIcon aria-hidden="true" />
<span className="sr-only">Open menu</span>
</Button>
</DropdownMenuTrigger>
@@ -327,7 +327,7 @@ export const WorkspaceSharingForm: FC<WorkspaceSharingFormProps> = ({
variant="subtle"
aria-label="Open menu"
>
<EllipsisVertical aria-hidden="true" />
<EllipsisVerticalIcon aria-hidden="true" />
<span className="sr-only">Open menu</span>
</Button>
</DropdownMenuTrigger>