chore: rename agent firewall flags (#27231)

* Alias --boundary-log-proxy-socket-path to
--agent-firewall-log-proxy-socket-path
* Also alias CODER_AGENT_BOUNDARY_LOG_PROXY_SOCKET_PATH to
CODER_AGENT_FIREWALL_LOG_PROXY_SOCKET_PATH
* Also Rename related variables and symbols to reflect the new name.

<!--

If you have used AI to produce some or all of this PR, please ensure you
have read our [AI Contribution
guidelines](https://coder.com/docs/about/contributing/AI_CONTRIBUTING)
before submitting.

-->

cli/agent.go

@@ -42,28 +42,28 @@ import (
 
 func workspaceAgent() *serpent.Command {
 	var (
-		logDir                         string
-		scriptDataDir                  string
-		pprofAddress                   string
-		noReap                         bool
-		sshMaxTimeout                  time.Duration
-		tailnetListenPort              int64
-		prometheusAddress              string
-		debugAddress                   string
-		slogHumanPath                  string
-		slogJSONPath                   string
-		slogStackdriverPath            string
-		blockFileTransfer              bool
-		blockReversePortForwarding     bool
-		blockLocalPortForwarding       bool
-		agentHeaderCommand             string
-		agentHeader                    []string
-		devcontainers                  bool
-		devcontainerProjectDiscovery   bool
-		devcontainerDiscoveryAutostart bool
-		socketServerEnabled            bool
-		socketPath                     string
-		boundaryLogProxySocketPath     string
+		logDir                          string
+		scriptDataDir                   string
+		pprofAddress                    string
+		noReap                          bool
+		sshMaxTimeout                   time.Duration
+		tailnetListenPort               int64
+		prometheusAddress               string
+		debugAddress                    string
+		slogHumanPath                   string
+		slogJSONPath                    string
+		slogStackdriverPath             string
+		blockFileTransfer               bool
+		blockReversePortForwarding      bool
+		blockLocalPortForwarding        bool
+		agentHeaderCommand              string
+		agentHeader                     []string
+		devcontainers                   bool
+		devcontainerProjectDiscovery    bool
+		devcontainerDiscoveryAutostart  bool
+		socketServerEnabled             bool
+		socketPath                      string
+		agentFirewallLogProxySocketPath string
 	)
 	agentAuth := &AgentAuth{}
 	cmd := &serpent.Command{
@@ -337,10 +337,10 @@ func workspaceAgent() *serpent.Command {
 						agentcontainers.WithProjectDiscovery(devcontainerProjectDiscovery),
 						agentcontainers.WithDiscoveryAutostart(devcontainerDiscoveryAutostart),
 					},
-					SocketPath:                 socketPath,
-					SocketServerEnabled:        socketServerEnabled,
-					BoundaryLogProxySocketPath: boundaryLogProxySocketPath,
-					ContextConfig:              contextConfig,
+					SocketPath:                      socketPath,
+					SocketServerEnabled:             socketServerEnabled,
+					AgentFirewallLogProxySocketPath: agentFirewallLogProxySocketPath,
+					ContextConfig:                   contextConfig,
 				})
 
 				if debugAddress != "" {
@@ -556,7 +556,21 @@ func workspaceAgent() *serpent.Command {
 			Default:     boundarylogproxy.DefaultSocketPath(),
 			Env:         "CODER_AGENT_BOUNDARY_LOG_PROXY_SOCKET_PATH",
 			Description: "The path for the boundary log proxy server Unix socket. Boundary should write audit logs to this socket.",
-			Value:       serpent.StringOf(&boundaryLogProxySocketPath),
+			Value:       serpent.StringOf(&agentFirewallLogProxySocketPath),
+			Hidden:      true,
+			UseInstead: []serpent.Option{
+				{
+					Flag: "agent-firewall-log-proxy-socket-path",
+					Env:  "CODER_AGENT_FIREWALL_LOG_PROXY_SOCKET_PATH",
+				},
+			},
+		},
+		{
+			Flag:        "agent-firewall-log-proxy-socket-path",
+			Default:     boundarylogproxy.DefaultSocketPath(),
+			Env:         "CODER_AGENT_FIREWALL_LOG_PROXY_SOCKET_PATH",
+			Description: "The path for the agent firewall log proxy server Unix socket. Agent firewall should write audit logs to this socket.",
+			Value:       serpent.StringOf(&agentFirewallLogProxySocketPath),
 		},
 	}
 	agentAuth.AttachOptions(cmd, false)

cli/testdata/coder_agent_--help.golden

@@ -31,6 +31,10 @@ OPTIONS:
       --log-stackdriver string, $CODER_AGENT_LOGGING_STACKDRIVER
           Output Stackdriver compatible logs to a given file.
 
+      --agent-firewall-log-proxy-socket-path string, $CODER_AGENT_FIREWALL_LOG_PROXY_SOCKET_PATH (default: /tmp/boundary-audit.sock)
+          The path for the agent firewall log proxy server Unix socket. Agent
+          firewall should write audit logs to this socket.
+
       --agent-header string-array, $CODER_AGENT_HEADER
           Additional HTTP headers added to all requests. Provide as key=value.
           Can be specified multiple times.
@@ -49,10 +53,6 @@ OPTIONS:
       --block-reverse-port-forwarding bool, $CODER_AGENT_BLOCK_REVERSE_PORT_FORWARDING (default: false)
           Block reverse port forwarding through the SSH server (ssh -R).
 
-      --boundary-log-proxy-socket-path string, $CODER_AGENT_BOUNDARY_LOG_PROXY_SOCKET_PATH (default: /tmp/boundary-audit.sock)
-          The path for the boundary log proxy server Unix socket. Boundary
-          should write audit logs to this socket.
-
       --debug-address string, $CODER_AGENT_DEBUG_ADDRESS (default: 127.0.0.1:2113)
           The bind address to serve a debug HTTP server.