From 660fa9478f5fc6ec8891693d902e807d203077a8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kayla=20=E3=81=AF=E3=81=AA?= <mckayla@hey.com>
Date: Wed, 13 May 2026 10:56:50 -0600
Subject: [PATCH] style(site): use shorthand for boolean JSX props (#25096)

---
 site/AGENTS.md                                            | 3 +++
 site/src/components/Loader/Loader.tsx                     | 2 +-
 site/src/components/Paywall/PopoverPaywall.tsx            | 2 +-
 site/src/components/SelectMenu/SelectMenu.tsx             | 2 +-
 site/src/components/UserAutocomplete/UserAutocomplete.tsx | 2 +-
 site/src/modules/resources/AgentExternal.tsx              | 2 +-
 site/src/modules/resources/AgentRow.tsx                   | 2 +-
 site/src/modules/resources/SSHButton/SSHButton.tsx        | 2 +-
 .../ClassicParameterFlowDeprecationWarning.test.tsx       | 2 +-
 .../workspaces/DynamicParameter/DynamicParameter.test.tsx | 6 +++---
 .../WorkspaceMoreActions/WorkspaceMoreActions.tsx         | 2 +-
 .../AgentsPage/components/AgentCreateForm.stories.tsx     | 2 +-
 .../components/LimitsTab/GroupLimitsSection.tsx           | 2 +-
 .../components/LimitsTab/UserOverridesSection.tsx         | 2 +-
 .../AgentsPage/components/Sidebar/AgentsSidebar.test.tsx  | 2 +-
 site/src/pages/AuditPage/AuditLogRow/AuditLogRow.tsx      | 2 +-
 site/src/pages/TaskPage/TaskPage.tsx                      | 2 +-
 .../WorkspacePage/WorkspaceActions/WorkspaceActions.tsx   | 8 ++++----
 18 files changed, 25 insertions(+), 22 deletions(-)

diff --git a/site/AGENTS.md b/site/AGENTS.md
index 194765ff2e..4d39493e52 100644
--- a/site/AGENTS.md
+++ b/site/AGENTS.md
@@ -101,6 +101,9 @@ Debug logs and pprof dumps use the same job name and commit SHA convention.
 - Do not use emdash (U+2014), endash (U+2013), or ` -- ` as punctuation
   in code, comments, string literals, or documentation. Use commas,
   semicolons, or periods instead. Restructure the sentence if needed.
+- For JSX boolean props that are `true`, use the shorthand form
+  (`<Foo prop />`) instead of `<Foo prop={true} />`. The two are
+  equivalent; the shorthand is the React convention and reduces noise.
 - **Avoid unnecessary indirection.** Inline single-use module-level
   constants, single-use aliases, and one-line helpers that just return a
   single field at the call site. Do not create wrapper hooks that only
diff --git a/site/src/components/Loader/Loader.tsx b/site/src/components/Loader/Loader.tsx
index b771b5fec6..3ba241dcf3 100644
--- a/site/src/components/Loader/Loader.tsx
+++ b/site/src/components/Loader/Loader.tsx
@@ -32,7 +32,7 @@ export const Loader: FC<LoaderProps> = ({
 				className,
 			)}
 		>
-			<Spinner aria-label={resolvedLabel} size={size} loading={true} />
+			<Spinner aria-label={resolvedLabel} size={size} loading />
 		</div>
 	);
 };
diff --git a/site/src/components/Paywall/PopoverPaywall.tsx b/site/src/components/Paywall/PopoverPaywall.tsx
index 2ce494cc5b..59929e8b78 100644
--- a/site/src/components/Paywall/PopoverPaywall.tsx
+++ b/site/src/components/Paywall/PopoverPaywall.tsx
@@ -17,7 +17,7 @@ export const PopoverPaywall: FC<PopoverPaywallProps> = ({
 			message={message}
 			description={description}
 			documentationLink={documentationLink}
-			compact={true}
+			compact
 		/>
 	);
 };
diff --git a/site/src/components/SelectMenu/SelectMenu.tsx b/site/src/components/SelectMenu/SelectMenu.tsx
index 4b03a9a709..78b2bf2659 100644
--- a/site/src/components/SelectMenu/SelectMenu.tsx
+++ b/site/src/components/SelectMenu/SelectMenu.tsx
@@ -80,7 +80,7 @@ export const SelectMenuSearch: FC<SearchFieldProps> = ({
 				"w-full border border-solid border-border [&_input]:text-sm",
 				className,
 			)}
-			autoFocus={true}
+			autoFocus
 			{...props}
 		/>
 	);
diff --git a/site/src/components/UserAutocomplete/UserAutocomplete.tsx b/site/src/components/UserAutocomplete/UserAutocomplete.tsx
index c8365316ad..7a0bf3f2b4 100644
--- a/site/src/components/UserAutocomplete/UserAutocomplete.tsx
+++ b/site/src/components/UserAutocomplete/UserAutocomplete.tsx
@@ -86,7 +86,7 @@ export const MemberAutocomplete: FC<MemberAutocompleteProps> = ({
 		<InnerAutocomplete<OrganizationMemberWithUserData>
 			error={membersQuery.error}
 			isFetching={membersQuery.isFetching}
-			shouldFilter={true}
+			shouldFilter
 			setFilter={setFilter}
 			users={membersQuery.data?.members}
 			{...props}
diff --git a/site/src/modules/resources/AgentExternal.tsx b/site/src/modules/resources/AgentExternal.tsx
index 5a39a50c36..1ea0645096 100644
--- a/site/src/modules/resources/AgentExternal.tsx
+++ b/site/src/modules/resources/AgentExternal.tsx
@@ -38,7 +38,7 @@ export const AgentExternal: FC<AgentExternalProps> = ({ agent, workspace }) => {
 				secret={false}
 				redactPattern={/CODER_AGENT_TOKEN="([^"]+)"/g}
 				redactReplacement={`CODER_AGENT_TOKEN="********"`}
-				showRevealButton={true}
+				showRevealButton
 			/>
 		</section>
 	);
diff --git a/site/src/modules/resources/AgentRow.tsx b/site/src/modules/resources/AgentRow.tsx
index 69739a53e5..46c306613e 100644
--- a/site/src/modules/resources/AgentRow.tsx
+++ b/site/src/modules/resources/AgentRow.tsx
@@ -523,7 +523,7 @@ export const AgentRow: FC<AgentRowProps> = ({
 								>
 									<Spinner
 										size="lg"
-										loading={true}
+										loading
 										className="text-content-secondary -ml-1"
 									/>
 									<span>{runningScriptsCount}</span>
diff --git a/site/src/modules/resources/SSHButton/SSHButton.tsx b/site/src/modules/resources/SSHButton/SSHButton.tsx
index 0a6761d0d9..39cca8cbf8 100644
--- a/site/src/modules/resources/SSHButton/SSHButton.tsx
+++ b/site/src/modules/resources/SSHButton/SSHButton.tsx
@@ -32,7 +32,7 @@ export const AgentSSHButton: FC<AgentSSHButtonProps> = ({
 
 	return (
 		<Popover>
-			<PopoverTrigger asChild={true}>
+			<PopoverTrigger asChild>
 				<Button size="sm" variant="subtle">
 					Connect via SSH
 					<ChevronDownIcon />
diff --git a/site/src/modules/workspaces/ClassicParameterFlowDeprecationWarning/ClassicParameterFlowDeprecationWarning.test.tsx b/site/src/modules/workspaces/ClassicParameterFlowDeprecationWarning/ClassicParameterFlowDeprecationWarning.test.tsx
index 1d9acfd935..a5bcd6e494 100644
--- a/site/src/modules/workspaces/ClassicParameterFlowDeprecationWarning/ClassicParameterFlowDeprecationWarning.test.tsx
+++ b/site/src/modules/workspaces/ClassicParameterFlowDeprecationWarning/ClassicParameterFlowDeprecationWarning.test.tsx
@@ -17,7 +17,7 @@ describe("ClassicParameterFlowDeprecationWarning", () => {
 			<ClassicParameterFlowDeprecationWarning
 				templateSettingsLink={`/templates/${defaultProps.organizationName}/${defaultProps.templateName}/settings`}
 				{...defaultProps}
-				isEnabled={true}
+				isEnabled
 			/>,
 		);
 
diff --git a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.test.tsx b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.test.tsx
index 3411434e4a..1426fe56e4 100644
--- a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.test.tsx
+++ b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.test.tsx
@@ -115,7 +115,7 @@ describe("DynamicParameter", () => {
 					parameter={mockStringParameter}
 					value=""
 					onChange={mockOnChange}
-					disabled={true}
+					disabled
 				/>,
 			);
 
@@ -626,7 +626,7 @@ describe("DynamicParameter", () => {
 					parameter={mockStringParameter}
 					value="autofilled_value"
 					onChange={mockOnChange}
-					autofill={true}
+					autofill
 				/>,
 			);
 
@@ -651,7 +651,7 @@ describe("DynamicParameter", () => {
 					parameter={mockStringParameter}
 					value="preset_value"
 					onChange={mockOnChange}
-					isPreset={true}
+					isPreset
 				/>,
 			);
 
diff --git a/site/src/modules/workspaces/WorkspaceMoreActions/WorkspaceMoreActions.tsx b/site/src/modules/workspaces/WorkspaceMoreActions/WorkspaceMoreActions.tsx
index 21a0c3a479..da4ac04ca9 100644
--- a/site/src/modules/workspaces/WorkspaceMoreActions/WorkspaceMoreActions.tsx
+++ b/site/src/modules/workspaces/WorkspaceMoreActions/WorkspaceMoreActions.tsx
@@ -275,7 +275,7 @@ export const WorkspaceMoreActions: FC<WorkspaceMoreActionsProps> = ({
 				workspaceOwner={workspace.owner_name}
 				workspaceName={workspace.name}
 				templateVersionId={workspace.latest_build.template_version_id}
-				isDeleting={true}
+				isDeleting
 			/>
 		</>
 	);
diff --git a/site/src/pages/AgentsPage/components/AgentCreateForm.stories.tsx b/site/src/pages/AgentsPage/components/AgentCreateForm.stories.tsx
index 1b7a96e8cf..d1d8c7aa32 100644
--- a/site/src/pages/AgentsPage/components/AgentCreateForm.stories.tsx
+++ b/site/src/pages/AgentsPage/components/AgentCreateForm.stories.tsx
@@ -660,7 +660,7 @@ export const OrgPickerTightSpacing: Story = {
 export const OrgChangeConfirmation: Story = {
 	render: () => (
 		<ConfirmDialog
-			open={true}
+			open
 			title="Change organization?"
 			description="Changing organization will remove your current attachments."
 			type="info"
diff --git a/site/src/pages/AgentsPage/components/LimitsTab/GroupLimitsSection.tsx b/site/src/pages/AgentsPage/components/LimitsTab/GroupLimitsSection.tsx
index b633a35150..cd97b9efa8 100644
--- a/site/src/pages/AgentsPage/components/LimitsTab/GroupLimitsSection.tsx
+++ b/site/src/pages/AgentsPage/components/LimitsTab/GroupLimitsSection.tsx
@@ -321,7 +321,7 @@ export const GroupLimitsSection: FC<GroupLimitsSectionProps> = ({
 						setPendingDeleteGroupId(null);
 					}}
 					isPending={deletePending}
-					open={true}
+					open
 					onOpenChange={(open) => !open && setPendingDeleteGroupId(null)}
 				/>
 			)}{" "}
diff --git a/site/src/pages/AgentsPage/components/LimitsTab/UserOverridesSection.tsx b/site/src/pages/AgentsPage/components/LimitsTab/UserOverridesSection.tsx
index ad25f7ae8c..f2c1a7d247 100644
--- a/site/src/pages/AgentsPage/components/LimitsTab/UserOverridesSection.tsx
+++ b/site/src/pages/AgentsPage/components/LimitsTab/UserOverridesSection.tsx
@@ -261,7 +261,7 @@ export const UserOverridesSection: FC<UserOverridesSectionProps> = ({
 						setPendingDeleteUserId(null);
 					}}
 					isPending={deletePending}
-					open={true}
+					open
 					onOpenChange={(open) => !open && setPendingDeleteUserId(null)}
 				/>
 			)}{" "}
diff --git a/site/src/pages/AgentsPage/components/Sidebar/AgentsSidebar.test.tsx b/site/src/pages/AgentsPage/components/Sidebar/AgentsSidebar.test.tsx
index df079ab99d..33fea58feb 100644
--- a/site/src/pages/AgentsPage/components/Sidebar/AgentsSidebar.test.tsx
+++ b/site/src/pages/AgentsPage/components/Sidebar/AgentsSidebar.test.tsx
@@ -334,7 +334,7 @@ describe("AgentsSidebar load-more behavior", () => {
 					{...defaultProps}
 					hasNextPage
 					onLoadMore={onLoadMore}
-					isFetchingNextPage={true}
+					isFetchingNextPage
 				/>
 			</Wrapper>,
 		);
diff --git a/site/src/pages/AuditPage/AuditLogRow/AuditLogRow.tsx b/site/src/pages/AuditPage/AuditLogRow/AuditLogRow.tsx
index 600ff9bba9..cc4a135ba3 100644
--- a/site/src/pages/AuditPage/AuditLogRow/AuditLogRow.tsx
+++ b/site/src/pages/AuditPage/AuditLogRow/AuditLogRow.tsx
@@ -124,7 +124,7 @@ export const AuditLogRow: FC<AuditLogRowProps> = ({
 									</div>
 
 									<div className="flex flex-row items-center gap-4">
-										<StatusPill isHttpCode={true} code={auditLog.status_code} />
+										<StatusPill isHttpCode code={auditLog.status_code} />
 
 										{/* With multi-org, there is not enough space so show
                       everything in a tooltip. */}
diff --git a/site/src/pages/TaskPage/TaskPage.tsx b/site/src/pages/TaskPage/TaskPage.tsx
index fca9824c2c..0efc87cca5 100644
--- a/site/src/pages/TaskPage/TaskPage.tsx
+++ b/site/src/pages/TaskPage/TaskPage.tsx
@@ -747,7 +747,7 @@ const TaskPaused: FC<TaskPausedProps> = ({
 				open={apiError !== undefined}
 				error={apiError}
 				onClose={resumeMutation.reset}
-				showDetail={true}
+				showDetail
 				workspaceOwner={workspace.owner_name}
 				workspaceName={workspace.name}
 				templateVersionId={workspace.latest_build.template_version_id}
diff --git a/site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.tsx b/site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.tsx
index a1953177bb..8a5cb54468 100644
--- a/site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.tsx
+++ b/site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.tsx
@@ -94,21 +94,21 @@ export const WorkspaceActions: FC<WorkspaceActionsProps> = ({
 			<UpdateButton
 				handleAction={handleUpdate}
 				isRunning={false}
-				requireActiveVersion={true}
+				requireActiveVersion
 			/>
 		),
 		updateAndRestart: (
 			<UpdateButton
 				handleAction={handleUpdate}
-				isRunning={true}
+				isRunning
 				requireActiveVersion={false}
 			/>
 		),
 		updateAndRestartRequireActiveVersion: (
 			<UpdateButton
 				handleAction={handleUpdate}
-				isRunning={true}
-				requireActiveVersion={true}
+				isRunning
+				requireActiveVersion
 			/>
 		),
 		updating: <UpdateButton loading handleAction={handleUpdate} />,