diff --git a/site/AGENTS.md b/site/AGENTS.md index 194765ff2e..4d39493e52 100644 --- a/site/AGENTS.md +++ b/site/AGENTS.md @@ -101,6 +101,9 @@ Debug logs and pprof dumps use the same job name and commit SHA convention. - Do not use emdash (U+2014), endash (U+2013), or ` -- ` as punctuation in code, comments, string literals, or documentation. Use commas, semicolons, or periods instead. Restructure the sentence if needed. +- For JSX boolean props that are `true`, use the shorthand form + (``) instead of ``. The two are + equivalent; the shorthand is the React convention and reduces noise. - **Avoid unnecessary indirection.** Inline single-use module-level constants, single-use aliases, and one-line helpers that just return a single field at the call site. Do not create wrapper hooks that only diff --git a/site/src/components/Loader/Loader.tsx b/site/src/components/Loader/Loader.tsx index b771b5fec6..3ba241dcf3 100644 --- a/site/src/components/Loader/Loader.tsx +++ b/site/src/components/Loader/Loader.tsx @@ -32,7 +32,7 @@ export const Loader: FC = ({ className, )} > - + ); }; diff --git a/site/src/components/Paywall/PopoverPaywall.tsx b/site/src/components/Paywall/PopoverPaywall.tsx index 2ce494cc5b..59929e8b78 100644 --- a/site/src/components/Paywall/PopoverPaywall.tsx +++ b/site/src/components/Paywall/PopoverPaywall.tsx @@ -17,7 +17,7 @@ export const PopoverPaywall: FC = ({ message={message} description={description} documentationLink={documentationLink} - compact={true} + compact /> ); }; diff --git a/site/src/components/SelectMenu/SelectMenu.tsx b/site/src/components/SelectMenu/SelectMenu.tsx index 4b03a9a709..78b2bf2659 100644 --- a/site/src/components/SelectMenu/SelectMenu.tsx +++ b/site/src/components/SelectMenu/SelectMenu.tsx @@ -80,7 +80,7 @@ export const SelectMenuSearch: FC = ({ "w-full border border-solid border-border [&_input]:text-sm", className, )} - autoFocus={true} + autoFocus {...props} /> ); diff --git a/site/src/components/UserAutocomplete/UserAutocomplete.tsx b/site/src/components/UserAutocomplete/UserAutocomplete.tsx index c8365316ad..7a0bf3f2b4 100644 --- a/site/src/components/UserAutocomplete/UserAutocomplete.tsx +++ b/site/src/components/UserAutocomplete/UserAutocomplete.tsx @@ -86,7 +86,7 @@ export const MemberAutocomplete: FC = ({ error={membersQuery.error} isFetching={membersQuery.isFetching} - shouldFilter={true} + shouldFilter setFilter={setFilter} users={membersQuery.data?.members} {...props} diff --git a/site/src/modules/resources/AgentExternal.tsx b/site/src/modules/resources/AgentExternal.tsx index 5a39a50c36..1ea0645096 100644 --- a/site/src/modules/resources/AgentExternal.tsx +++ b/site/src/modules/resources/AgentExternal.tsx @@ -38,7 +38,7 @@ export const AgentExternal: FC = ({ agent, workspace }) => { secret={false} redactPattern={/CODER_AGENT_TOKEN="([^"]+)"/g} redactReplacement={`CODER_AGENT_TOKEN="********"`} - showRevealButton={true} + showRevealButton /> ); diff --git a/site/src/modules/resources/AgentRow.tsx b/site/src/modules/resources/AgentRow.tsx index 69739a53e5..46c306613e 100644 --- a/site/src/modules/resources/AgentRow.tsx +++ b/site/src/modules/resources/AgentRow.tsx @@ -523,7 +523,7 @@ export const AgentRow: FC = ({ > {runningScriptsCount} diff --git a/site/src/modules/resources/SSHButton/SSHButton.tsx b/site/src/modules/resources/SSHButton/SSHButton.tsx index 0a6761d0d9..39cca8cbf8 100644 --- a/site/src/modules/resources/SSHButton/SSHButton.tsx +++ b/site/src/modules/resources/SSHButton/SSHButton.tsx @@ -32,7 +32,7 @@ export const AgentSSHButton: FC = ({ return ( - +