From 62380651858db092dc76b0f92a1b919ce406d4ae Mon Sep 17 00:00:00 2001
From: Spike Curtis <spike@coder.com>
Date: Mon, 22 Dec 2025 10:21:39 +0400
Subject: [PATCH] test: use not before in TestAgentConnectionMonitor_* (#21332)

fixes https://github.com/coder/internal/issues/1203

The matcher I wrote for TestAgentConnectionMonitor tested that `last_disconnected_at` was strictly _after_ the start of the test to ensure it was updated.

This is too strict of a test because Windows in particular doesn't have high-resolution timers, so it's entirely possible to get the exact same timestamp from subsequent calls to `time.Now()`. This PR switches the test to _not before_ to cover this case. The results are just as valid because we always initialize the `last_disconnected_at` to something well before the test starts.
---
 coderd/workspaceagentsrpc_internal_test.go | 30 +++++++++++-----------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/coderd/workspaceagentsrpc_internal_test.go b/coderd/workspaceagentsrpc_internal_test.go
index 88d08bc4e3..1cbc66e49c 100644
--- a/coderd/workspaceagentsrpc_internal_test.go
+++ b/coderd/workspaceagentsrpc_internal_test.go
@@ -94,7 +94,7 @@ func TestAgentConnectionMonitor_ContextCancel(t *testing.T) {
 				Return(nil)
 			mDB.EXPECT().UpdateWorkspaceAgentConnectionByID(
 				gomock.Any(),
-				connectionUpdate(agentID, replicaID, withDisconnectedAfter(now)),
+				connectionUpdate(agentID, replicaID, withDisconnectedNotBefore(now)),
 			).
 				After(connected).
 				Times(1).
@@ -172,7 +172,7 @@ func TestAgentConnectionMonitor_PingTimeout(t *testing.T) {
 		Return(nil)
 	mDB.EXPECT().UpdateWorkspaceAgentConnectionByID(
 		gomock.Any(),
-		connectionUpdate(agent.ID, replicaID, withDisconnectedAfter(now)),
+		connectionUpdate(agent.ID, replicaID, withDisconnectedNotBefore(now)),
 	).
 		After(connected).
 		Times(1).
@@ -235,7 +235,7 @@ func TestAgentConnectionMonitor_BuildOutdated(t *testing.T) {
 		Return(nil)
 	mDB.EXPECT().UpdateWorkspaceAgentConnectionByID(
 		gomock.Any(),
-		connectionUpdate(agent.ID, replicaID, withDisconnectedAfter(now)),
+		connectionUpdate(agent.ID, replicaID, withDisconnectedNotBefore(now)),
 	).
 		After(connected).
 		Times(1).
@@ -320,7 +320,7 @@ func TestAgentConnectionMonitor_StartClose(t *testing.T) {
 		Return(nil)
 	mDB.EXPECT().UpdateWorkspaceAgentConnectionByID(
 		gomock.Any(),
-		connectionUpdate(agent.ID, replicaID, withDisconnectedAfter(now)),
+		connectionUpdate(agent.ID, replicaID, withDisconnectedNotBefore(now)),
 	).
 		After(connected).
 		Times(1).
@@ -423,10 +423,10 @@ func (f *fakeUpdater) getUpdates() int {
 }
 
 type connectionUpdateMatcher struct {
-	agentID           uuid.UUID
-	replicaID         uuid.UUID
-	disconnectedAt    sql.NullTime
-	disconnectedAfter sql.NullTime
+	agentID               uuid.UUID
+	replicaID             uuid.UUID
+	disconnectedAt        sql.NullTime
+	disconnectedNotBefore sql.NullTime
 }
 
 type connectionUpdateMatcherOption func(m connectionUpdateMatcher) connectionUpdateMatcher
@@ -442,9 +442,9 @@ func connectionUpdate(id, replica uuid.UUID, opts ...connectionUpdateMatcherOpti
 	return m
 }
 
-func withDisconnectedAfter(t time.Time) connectionUpdateMatcherOption {
+func withDisconnectedNotBefore(t time.Time) connectionUpdateMatcherOption {
 	return func(m connectionUpdateMatcher) connectionUpdateMatcher {
-		m.disconnectedAfter = sql.NullTime{
+		m.disconnectedNotBefore = sql.NullTime{
 			Valid: true,
 			Time:  t,
 		}
@@ -476,14 +476,14 @@ func (m connectionUpdateMatcher) Matches(x interface{}) bool {
 	if args.LastConnectedReplicaID.UUID != m.replicaID {
 		return false
 	}
-	if m.disconnectedAfter.Valid {
+	if m.disconnectedNotBefore.Valid {
 		if !args.DisconnectedAt.Valid {
 			return false
 		}
-		if !args.DisconnectedAt.Time.After(m.disconnectedAfter.Time) {
+		if args.DisconnectedAt.Time.Before(m.disconnectedNotBefore.Time) {
 			return false
 		}
-		// disconnectedAfter takes precedence over disconnectedAt
+		// disconnectedNotBefore takes precedence over disconnectedAt
 	} else if args.DisconnectedAt != m.disconnectedAt {
 		return false
 	}
@@ -491,8 +491,8 @@ func (m connectionUpdateMatcher) Matches(x interface{}) bool {
 }
 
 func (m connectionUpdateMatcher) String() string {
-	return fmt.Sprintf("{agent=%s, replica=%s, disconnectedAt=%v, disconnectedAfter=%v}",
-		m.agentID.String(), m.replicaID.String(), m.disconnectedAt, m.disconnectedAfter)
+	return fmt.Sprintf("{agent=%s, replica=%s, disconnectedAt=%v, disconnectedNotBefore=%v}",
+		m.agentID.String(), m.replicaID.String(), m.disconnectedAt, m.disconnectedNotBefore)
 }
 
 func (connectionUpdateMatcher) Got(x interface{}) string {