From 611fbd8215cafcd717c722611032ac32a7899c53 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Tue, 18 Jul 2023 21:58:50 +0300 Subject: [PATCH] test(coderd): fix TestWorkspaceWatcher skipped pending state (#8584) --- coderd/workspaces_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go index edd62932a1..839bef3c60 100644 --- a/coderd/workspaces_test.go +++ b/coderd/workspaces_test.go @@ -2158,8 +2158,10 @@ func TestWorkspaceWatcher(t *testing.T) { _ = coderdtest.CreateWorkspaceBuild(t, client, workspace, database.WorkspaceTransitionStart, func(req *codersdk.CreateWorkspaceBuildRequest) { req.TemplateVersionID = updatedVersion.ID }) - wait("workspace build pending", func(w codersdk.Workspace) bool { - return w.LatestBuild.Status == codersdk.WorkspaceStatusPending + // We want to verify pending state here, but it's possible that we reach + // failed state fast enough that we never see pending. + wait("workspace build pending or failed", func(w codersdk.Workspace) bool { + return w.LatestBuild.Status == codersdk.WorkspaceStatusPending || w.LatestBuild.Status == codersdk.WorkspaceStatusFailed }) wait("workspace build failed", func(w codersdk.Workspace) bool { return w.LatestBuild.Status == codersdk.WorkspaceStatusFailed