feat: add inactivity cleanup and failure cleanup configuration fields to Template Schedule Form (#7402)

* added workspace actions entitlement * added workspace actions experiment * added new route for template enterprise meta * removing new route; repurposing old * add new fields to get endpoints * removed workspace actions experiment * added logic to enterprise template store * added new form fields * feature flagged new fields * fix validation * fixed submit btn * fix tests * changed ttl defaults * added FE tests * added BE tests * fixed lint * adjusted comment language * fixing unstaged changes check * fix test * Update coderd/database/migrations/000122_add_template_cleanup_ttls.down.sql Co-authored-by: Dean Sheather <dean@deansheather.com> * Update coderd/database/migrations/000122_add_template_cleanup_ttls.up.sql Co-authored-by: Dean Sheather <dean@deansheather.com> --------- Co-authored-by: Dean Sheather <dean@deansheather.com>
2026-09-24 15:04:27 +08:00 · 2023-05-05 08:19:26 -07:00
parent 3632ac8c01
commit 5ffa6dae50
33 changed files with 578 additions and 59 deletions
@@ -604,6 +604,90 @@ func TestPatchTemplateMeta(t *testing.T) {
 		})
 	})

+	t.Run("CleanupTTLs", func(t *testing.T) {
+		t.Parallel()
+
+		const (
+			failureTTL    = 7 * 24 * time.Hour
+			inactivityTTL = 180 * 24 * time.Hour
+		)
+
+		t.Run("OK", func(t *testing.T) {
+			t.Parallel()
+
+			var setCalled int64
+			client := coderdtest.New(t, &coderdtest.Options{
+				TemplateScheduleStore: schedule.MockTemplateScheduleStore{
+					SetFn: func(ctx context.Context, db database.Store, template database.Template, options schedule.TemplateScheduleOptions) (database.Template, error) {
+						if atomic.AddInt64(&setCalled, 1) == 2 {
+							require.Equal(t, failureTTL, options.FailureTTL)
+							require.Equal(t, inactivityTTL, options.InactivityTTL)
+						}
+						template.FailureTTL = int64(options.FailureTTL)
+						template.InactivityTTL = int64(options.InactivityTTL)
+						return template, nil
+					},
+				},
+			})
+			user := coderdtest.CreateFirstUser(t, client)
+			version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil)
+			template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID, func(ctr *codersdk.CreateTemplateRequest) {
+				ctr.FailureTTLMillis = ptr.Ref(0 * time.Hour.Milliseconds())
+				ctr.InactivityTTLMillis = ptr.Ref(0 * time.Hour.Milliseconds())
+			})
+
+			ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
+			defer cancel()
+
+			got, err := client.UpdateTemplateMeta(ctx, template.ID, codersdk.UpdateTemplateMeta{
+				Name:                         template.Name,
+				DisplayName:                  template.DisplayName,
+				Description:                  template.Description,
+				Icon:                         template.Icon,
+				DefaultTTLMillis:             0,
+				MaxTTLMillis:                 0,
+				AllowUserCancelWorkspaceJobs: template.AllowUserCancelWorkspaceJobs,
+				FailureTTLMillis:             failureTTL.Milliseconds(),
+				InactivityTTLMillis:          inactivityTTL.Milliseconds(),
+			})
+			require.NoError(t, err)
+
+			require.EqualValues(t, 2, atomic.LoadInt64(&setCalled))
+			require.Equal(t, failureTTL.Milliseconds(), got.FailureTTLMillis)
+			require.Equal(t, inactivityTTL.Milliseconds(), got.InactivityTTLMillis)
+		})
+
+		t.Run("IgnoredUnlicensed", func(t *testing.T) {
+			t.Parallel()
+
+			client := coderdtest.New(t, nil)
+			user := coderdtest.CreateFirstUser(t, client)
+			version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil)
+			template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID, func(ctr *codersdk.CreateTemplateRequest) {
+				ctr.FailureTTLMillis = ptr.Ref(0 * time.Hour.Milliseconds())
+				ctr.InactivityTTLMillis = ptr.Ref(0 * time.Hour.Milliseconds())
+			})
+
+			ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
+			defer cancel()
+
+			got, err := client.UpdateTemplateMeta(ctx, template.ID, codersdk.UpdateTemplateMeta{
+				Name:                         template.Name,
+				DisplayName:                  template.DisplayName,
+				Description:                  template.Description,
+				Icon:                         template.Icon,
+				DefaultTTLMillis:             template.DefaultTTLMillis,
+				MaxTTLMillis:                 template.MaxTTLMillis,
+				AllowUserCancelWorkspaceJobs: template.AllowUserCancelWorkspaceJobs,
+				FailureTTLMillis:             failureTTL.Milliseconds(),
+				InactivityTTLMillis:          inactivityTTL.Milliseconds(),
+			})
+			require.NoError(t, err)
+			require.Zero(t, got.FailureTTLMillis)
+			require.Zero(t, got.InactivityTTLMillis)
+		})
+	})
+
 	t.Run("AllowUserScheduling", func(t *testing.T) {
 		t.Parallel()