From 5f60a8d9e35b8f4dea940e082a8ec347cdd27a57 Mon Sep 17 00:00:00 2001 From: Ethan <39577870+ethanndickson@users.noreply.github.com> Date: Fri, 1 Nov 2024 23:22:36 +1100 Subject: [PATCH] fix: create contexts per sub-test to fix flake (#15314) Flake seen here: https://github.com/coder/coder/actions/runs/11624011543/job/32371950701 https://coder.com/blog/go-testing-contexts-and-t-parallel --- coderd/database/querier_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/coderd/database/querier_test.go b/coderd/database/querier_test.go index 41fca8d0a4..b3fde5a558 100644 --- a/coderd/database/querier_test.go +++ b/coderd/database/querier_test.go @@ -620,7 +620,6 @@ func TestGetAuthorizedWorkspacesAndAgentsByOwnerID(t *testing.T) { t.SkipNow() } - ctx := testutil.Context(t, testutil.WaitLong) sqlDB := testSQLDB(t) err := migrations.Up(sqlDB) require.NoError(t, err) @@ -695,6 +694,7 @@ func TestGetAuthorizedWorkspacesAndAgentsByOwnerID(t *testing.T) { } t.Run("sqlQuerier", func(t *testing.T) { t.Parallel() + ctx := testutil.Context(t, testutil.WaitMedium) userSubject, _, err := httpmw.UserRBACSubject(ctx, db, user.ID, rbac.ExpandableScope(rbac.ScopeAll)) require.NoError(t, err) @@ -717,6 +717,7 @@ func TestGetAuthorizedWorkspacesAndAgentsByOwnerID(t *testing.T) { t.Run("dbauthz", func(t *testing.T) { t.Parallel() + ctx := testutil.Context(t, testutil.WaitMedium) authzdb := dbauthz.New(db, authorizer, slogtest.Make(t, &slogtest.Options{}), coderdtest.AccessControlStorePointer())