chore: move /gitauth to /externalauth on the frontend (#9954)

* chore: move `/gitauth` to `/externalauth` on the frontend

This actually took a lot more jank than anticipated,
so I wanted to split this up before adding the ability
to embed new providers.

* Rename FE

* Fix em' up

* Fix linting error

* Fix e2e tests

* chore: update helm golden files

coderd/httpmw/externalauthparam.go

@@ -0,0 +1,40 @@
+package httpmw
+
+import (
+	"context"
+	"net/http"
+
+	"github.com/go-chi/chi/v5"
+
+	"github.com/coder/coder/v2/coderd/externalauth"
+	"github.com/coder/coder/v2/coderd/httpapi"
+)
+
+type externalAuthParamContextKey struct{}
+
+func ExternalAuthParam(r *http.Request) *externalauth.Config {
+	config, ok := r.Context().Value(externalAuthParamContextKey{}).(*externalauth.Config)
+	if !ok {
+		panic("developer error: external auth param middleware not provided")
+	}
+	return config
+}
+
+func ExtractExternalAuthParam(configs []*externalauth.Config) func(next http.Handler) http.Handler {
+	configByID := make(map[string]*externalauth.Config)
+	for _, c := range configs {
+		configByID[c.ID] = c
+	}
+	return func(next http.Handler) http.Handler {
+		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			config, ok := configByID[chi.URLParam(r, "externalauth")]
+			if !ok {
+				httpapi.ResourceNotFound(w)
+				return
+			}
+
+			r = r.WithContext(context.WithValue(r.Context(), externalAuthParamContextKey{}, config))
+			next.ServeHTTP(w, r)
+		})
+	}
+}

coderd/httpmw/externalauthparam_test.go

@@ -9,25 +9,25 @@ import (
 	"github.com/go-chi/chi/v5"
 	"github.com/stretchr/testify/require"
 
-	"github.com/coder/coder/v2/coderd/gitauth"
+	"github.com/coder/coder/v2/coderd/externalauth"
 	"github.com/coder/coder/v2/coderd/httpmw"
 )
 
 //nolint:bodyclose
-func TestGitAuthParam(t *testing.T) {
+func TestExternalAuthParam(t *testing.T) {
 	t.Parallel()
 	t.Run("Found", func(t *testing.T) {
 		t.Parallel()
 		routeCtx := chi.NewRouteContext()
-		routeCtx.URLParams.Add("gitauth", "my-id")
+		routeCtx.URLParams.Add("externalauth", "my-id")
 		r := httptest.NewRequest(http.MethodGet, "/", nil)
 		r = r.WithContext(context.WithValue(r.Context(), chi.RouteCtxKey, routeCtx))
 		res := httptest.NewRecorder()
 
-		httpmw.ExtractGitAuthParam([]*gitauth.Config{{
+		httpmw.ExtractExternalAuthParam([]*externalauth.Config{{
 			ID: "my-id",
 		}})(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-			require.Equal(t, "my-id", httpmw.GitAuthParam(r).ID)
+			require.Equal(t, "my-id", httpmw.ExternalAuthParam(r).ID)
 			w.WriteHeader(http.StatusOK)
 		})).ServeHTTP(res, r)
 
@@ -37,12 +37,12 @@ func TestGitAuthParam(t *testing.T) {
 	t.Run("NotFound", func(t *testing.T) {
 		t.Parallel()
 		routeCtx := chi.NewRouteContext()
-		routeCtx.URLParams.Add("gitauth", "my-id")
+		routeCtx.URLParams.Add("externalauth", "my-id")
 		r := httptest.NewRequest(http.MethodGet, "/", nil)
 		r = r.WithContext(context.WithValue(r.Context(), chi.RouteCtxKey, routeCtx))
 		res := httptest.NewRecorder()
 
-		httpmw.ExtractGitAuthParam([]*gitauth.Config{})(nil).ServeHTTP(res, r)
+		httpmw.ExtractExternalAuthParam([]*externalauth.Config{})(nil).ServeHTTP(res, r)
 
 		require.Equal(t, http.StatusNotFound, res.Result().StatusCode)
 	})

coderd/httpmw/gitauthparam.go

@@ -1,40 +0,0 @@
-package httpmw
-
-import (
-	"context"
-	"net/http"
-
-	"github.com/go-chi/chi/v5"
-
-	"github.com/coder/coder/v2/coderd/gitauth"
-	"github.com/coder/coder/v2/coderd/httpapi"
-)
-
-type gitAuthParamContextKey struct{}
-
-func GitAuthParam(r *http.Request) *gitauth.Config {
-	config, ok := r.Context().Value(gitAuthParamContextKey{}).(*gitauth.Config)
-	if !ok {
-		panic("developer error: gitauth param middleware not provided")
-	}
-	return config
-}
-
-func ExtractGitAuthParam(configs []*gitauth.Config) func(next http.Handler) http.Handler {
-	configByID := make(map[string]*gitauth.Config)
-	for _, c := range configs {
-		configByID[c.ID] = c
-	}
-	return func(next http.Handler) http.Handler {
-		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-			config, ok := configByID[chi.URLParam(r, "gitauth")]
-			if !ok {
-				httpapi.ResourceNotFound(w)
-				return
-			}
-
-			r = r.WithContext(context.WithValue(r.Context(), gitAuthParamContextKey{}, config))
-			next.ServeHTTP(w, r)
-		})
-	}
-}

coderd/httpmw/patternmatcher/routepatterns_test.go

@@ -65,9 +65,9 @@ func Test_RoutePatterns(t *testing.T) {
 				"/api/**",
 				"/@*/*/apps/**",
 				"/%40*/*/apps/**",
-				"/gitauth/*/callback",
+				"/externalauth/*/callback",
 			},
-			output: "^(/api/?|/api/.+/?|/@[^/]+/[^/]+/apps/.+/?|/%40[^/]+/[^/]+/apps/.+/?|/gitauth/[^/]+/callback/?)$",
+			output: "^(/api/?|/api/.+/?|/@[^/]+/[^/]+/apps/.+/?|/%40[^/]+/[^/]+/apps/.+/?|/externalauth/[^/]+/callback/?)$",
 		},
 		{
 			name: "Slash",