From 50d9206950a26c5497ce9df676bbf4190a02bbd2 Mon Sep 17 00:00:00 2001 From: Steven Masley Date: Thu, 3 Oct 2024 20:28:04 -0500 Subject: [PATCH] chore: fix rbac_gen to allow parallel `make gen` (#14966) Closes https://github.com/coder/coder/issues/14702 --- Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 4bf7fb9263..990a109d5e 100644 --- a/Makefile +++ b/Makefile @@ -629,7 +629,10 @@ coderd/rbac/object_gen.go: scripts/rbacgen/rbacobject.gotmpl scripts/rbacgen/mai go run scripts/rbacgen/main.go rbac > coderd/rbac/object_gen.go codersdk/rbacresources_gen.go: scripts/rbacgen/codersdk.gotmpl scripts/rbacgen/main.go coderd/rbac/object.go coderd/rbac/policy/policy.go - go run scripts/rbacgen/main.go codersdk > codersdk/rbacresources_gen.go + # Do no overwrite codersdk/rbacresources_gen.go directly, as it would make the file empty, breaking + # the `codersdk` package and any parallel build targets. + go run scripts/rbacgen/main.go codersdk > /tmp/rbacresources_gen.go + mv /tmp/rbacresources_gen.go codersdk/rbacresources_gen.go site/src/api/rbacresourcesGenerated.ts: scripts/rbacgen/codersdk.gotmpl scripts/rbacgen/main.go coderd/rbac/object.go coderd/rbac/policy/policy.go go run scripts/rbacgen/main.go typescript > "$@"