From 4f1ddeeaad50d5c6a05b2ce44684bdb272abdd40 Mon Sep 17 00:00:00 2001 From: Zach <3724288+zedkipp@users.noreply.github.com> Date: Wed, 25 Feb 2026 13:15:03 -0700 Subject: [PATCH] fix(site): scope TemplateSettingsPage validation error assertion to form (#22308) The sonner migration (https://github.com/coder/coder/pull/22258) shows validation errors in both the inline form field and a toast. Scoping the assertion to the form element avoids flaky matches against the toast. Co-authored-by: Claude Opus 4.6 --- .../TemplateSettingsPage.jest.tsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.jest.tsx b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.jest.tsx index e5e032cccb..d399714e67 100644 --- a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.jest.tsx +++ b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.jest.tsx @@ -8,7 +8,7 @@ import { waitForLoaderToBeRemoved, } from "testHelpers/renderHelpers"; import { server } from "testHelpers/server"; -import { screen, waitFor } from "@testing-library/react"; +import { screen, waitFor, within } from "@testing-library/react"; import userEvent from "@testing-library/user-event"; import { API, withDefaultFeatures } from "api/api"; import type { UpdateTemplateMeta } from "api/typesGenerated"; @@ -131,8 +131,11 @@ describe("TemplateSettingsPage", () => { ); await fillAndSubmitForm(validFormValues); await waitFor(() => expect(API.updateTemplateMeta).toBeCalledTimes(1)); + const form = await screen.findByRole("form", { + name: /template settings/i, + }); expect( - await screen.findByText( + await within(form).findByText( "This value is already in use and should be unique.", ), ).toBeInTheDocument();