feat: add display_name field to groups (#8740)

* feat: add display_name field to groups

This is a non-unique human friendly group name for display
purposes. This means a display name can be used instead of
using an environment var to remap groups with OIDC names to
Coder names. Now groups can retain the OIDC name for mapping,
and use a display name for display purposes.

enterprise/coderd/groups.go

@@ -56,6 +56,7 @@ func (api *API) postGroupByOrganization(rw http.ResponseWriter, r *http.Request)
 	group, err := api.Database.InsertGroup(ctx, database.InsertGroupParams{
 		ID:             uuid.New(),
 		Name:           req.Name,
+		DisplayName:    req.DisplayName,
 		OrganizationID: org.ID,
 		AvatarURL:      req.AvatarURL,
 		QuotaAllowance: int32(req.QuotaAllowance),
@@ -177,6 +178,7 @@ func (api *API) patchGroup(rw http.ResponseWriter, r *http.Request) {
 			ID:             group.ID,
 			AvatarURL:      group.AvatarURL,
 			Name:           group.Name,
+			DisplayName:    group.DisplayName,
 			QuotaAllowance: group.QuotaAllowance,
 		}
 
@@ -190,6 +192,9 @@ func (api *API) patchGroup(rw http.ResponseWriter, r *http.Request) {
 		if req.QuotaAllowance != nil {
 			updateGroupParams.QuotaAllowance = int32(*req.QuotaAllowance)
 		}
+		if req.DisplayName != nil {
+			updateGroupParams.DisplayName = *req.DisplayName
+		}
 
 		group, err = tx.UpdateGroupByID(ctx, updateGroupParams)
 		if err != nil {
@@ -395,9 +400,11 @@ func convertGroup(g database.Group, users []database.User) codersdk.Group {
 	for _, user := range users {
 		orgs[user.ID] = []uuid.UUID{g.OrganizationID}
 	}
+
 	return codersdk.Group{
 		ID:             g.ID,
 		Name:           g.Name,
+		DisplayName:    g.DisplayName,
 		OrganizationID: g.OrganizationID,
 		AvatarURL:      g.AvatarURL,
 		QuotaAllowance: int(g.QuotaAllowance),

enterprise/coderd/groups_test.go

@@ -37,6 +37,7 @@ func TestCreateGroup(t *testing.T) {
 		require.Equal(t, "hi", group.Name)
 		require.Equal(t, "https://example.com", group.AvatarURL)
 		require.Empty(t, group.Members)
+		require.Empty(t, group.DisplayName)
 		require.NotEqual(t, uuid.Nil.String(), group.ID.String())
 	})
 
@@ -124,11 +125,45 @@ func TestPatchGroup(t *testing.T) {
 				codersdk.FeatureTemplateRBAC: 1,
 			},
 		}})
+		const displayName = "foobar"
 		ctx := testutil.Context(t, testutil.WaitLong)
 		group, err := client.CreateGroup(ctx, user.OrganizationID, codersdk.CreateGroupRequest{
 			Name:           "hi",
 			AvatarURL:      "https://example.com",
 			QuotaAllowance: 10,
+			DisplayName:    "",
+		})
+		require.NoError(t, err)
+		require.Equal(t, 10, group.QuotaAllowance)
+
+		group, err = client.PatchGroup(ctx, group.ID, codersdk.PatchGroupRequest{
+			Name:           "bye",
+			AvatarURL:      ptr.Ref("https://google.com"),
+			QuotaAllowance: ptr.Ref(20),
+			DisplayName:    ptr.Ref(displayName),
+		})
+		require.NoError(t, err)
+		require.Equal(t, displayName, group.DisplayName)
+		require.Equal(t, "bye", group.Name)
+		require.Equal(t, "https://google.com", group.AvatarURL)
+		require.Equal(t, 20, group.QuotaAllowance)
+	})
+
+	t.Run("DisplayNameUnchanged", func(t *testing.T) {
+		t.Parallel()
+
+		client, user := coderdenttest.New(t, &coderdenttest.Options{LicenseOptions: &coderdenttest.LicenseOptions{
+			Features: license.Features{
+				codersdk.FeatureTemplateRBAC: 1,
+			},
+		}})
+		const displayName = "foobar"
+		ctx := testutil.Context(t, testutil.WaitLong)
+		group, err := client.CreateGroup(ctx, user.OrganizationID, codersdk.CreateGroupRequest{
+			Name:           "hi",
+			AvatarURL:      "https://example.com",
+			QuotaAllowance: 10,
+			DisplayName:    displayName,
 		})
 		require.NoError(t, err)
 		require.Equal(t, 10, group.QuotaAllowance)
@@ -139,6 +174,7 @@ func TestPatchGroup(t *testing.T) {
 			QuotaAllowance: ptr.Ref(20),
 		})
 		require.NoError(t, err)
+		require.Equal(t, displayName, group.DisplayName)
 		require.Equal(t, "bye", group.Name)
 		require.Equal(t, "https://google.com", group.AvatarURL)
 		require.Equal(t, 20, group.QuotaAllowance)