From 4b3ed61210ce37e8eb0a746dc187ae779fc56639 Mon Sep 17 00:00:00 2001 From: Danielle Maywood Date: Sun, 8 Mar 2026 17:45:39 +0000 Subject: [PATCH] refactor(site): replace double-negation with Boolean() in AgentsPage (#22814) --- site/src/pages/AgentsPage/AgentChatInput.tsx | 6 ++++-- .../AgentsPage/ChatModelAdminPanel/ModelConfigFields.tsx | 6 +++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/site/src/pages/AgentsPage/AgentChatInput.tsx b/site/src/pages/AgentsPage/AgentChatInput.tsx index ec5b8bf451..db9904c96b 100644 --- a/site/src/pages/AgentsPage/AgentChatInput.tsx +++ b/site/src/pages/AgentsPage/AgentChatInput.tsx @@ -421,11 +421,13 @@ export const AgentChatInput = memo( // Track whether the editor has content so we can gate the // send button without a controlled value prop. - const [hasContent, setHasContent] = useState(() => !!initialValue?.trim()); + const [hasContent, setHasContent] = useState(() => + Boolean(initialValue?.trim()), + ); const handleContentChange = useCallback( (content: string) => { - setHasContent(!!content.trim()); + setHasContent(Boolean(content.trim())); onContentChange?.(content); }, [onContentChange], diff --git a/site/src/pages/AgentsPage/ChatModelAdminPanel/ModelConfigFields.tsx b/site/src/pages/AgentsPage/ChatModelAdminPanel/ModelConfigFields.tsx index 54bd3a54b6..f8c0f2197b 100644 --- a/site/src/pages/AgentsPage/ChatModelAdminPanel/ModelConfigFields.tsx +++ b/site/src/pages/AgentsPage/ChatModelAdminPanel/ModelConfigFields.tsx @@ -111,7 +111,7 @@ const InputField: FC< placeholder={placeholder} {...fieldProps} disabled={disabled} - aria-invalid={!!fieldError} + aria-invalid={Boolean(fieldError)} aria-describedby={fieldError ? errorId : undefined} /> {fieldError && ( @@ -171,7 +171,7 @@ const SelectField: FC< "h-9 min-w-0 text-[13px]", fieldError && "border-content-destructive", )} - aria-invalid={!!fieldError} + aria-invalid={Boolean(fieldError)} aria-describedby={fieldError ? errorId : undefined} > @@ -235,7 +235,7 @@ const JSONField: FC< placeholder={placeholder} {...fieldProps} disabled={disabled} - aria-invalid={!!fieldError} + aria-invalid={Boolean(fieldError)} aria-describedby={fieldError ? errorId : undefined} /> {fieldError && (