From 4691ef39cdf6a8240c49386aaa812797be370d36 Mon Sep 17 00:00:00 2001
From: "blinkagent[bot]" <237617714+blinkagent[bot]@users.noreply.github.com>
Date: Tue, 23 Jun 2026 11:45:58 +0500
Subject: [PATCH] feat(site): clarify why secret name is disabled when editing
 (#26553)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Adds helper text under the disabled `Name` field in the Edit secret
dialog so users understand why it can't be changed:

> Unique identifier (can’t be changed).

Matches the existing pattern used elsewhere (e.g. AI settings). The
secret name is the resource identifier in the API path (`PATCH
/api/v2/users/{user}/secrets/{name}`) and `UpdateUserSecretRequest` has
no `name` field, so rename isn't supported server-side.

Created on behalf of @matifali.

---------

Co-authored-by: blink-so[bot] <211532188+blink-so[bot]@users.noreply.github.com>
---
 .../src/pages/UserSettingsPage/SecretsPage/SecretDialog.tsx | 6 +++++-
 .../SecretsPage/SecretsPageView.stories.tsx                 | 3 +++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/site/src/pages/UserSettingsPage/SecretsPage/SecretDialog.tsx b/site/src/pages/UserSettingsPage/SecretsPage/SecretDialog.tsx
index 2733c82a27..4e6709ed71 100644
--- a/site/src/pages/UserSettingsPage/SecretsPage/SecretDialog.tsx
+++ b/site/src/pages/UserSettingsPage/SecretsPage/SecretDialog.tsx
@@ -233,7 +233,11 @@ const SecretFields: FC<SecretFieldsProps> = ({
 	return (
 		<>
 			<FormField
-				field={getFieldHelpers("name")}
+				field={getFieldHelpers("name", {
+					helperText: disableName
+						? "Unique identifier (can’t be changed)."
+						: undefined,
+				})}
 				label={
 					showRequiredLabels ? (
 						<RequiredFieldLabel>Name</RequiredFieldLabel>
diff --git a/site/src/pages/UserSettingsPage/SecretsPage/SecretsPageView.stories.tsx b/site/src/pages/UserSettingsPage/SecretsPage/SecretsPageView.stories.tsx
index 9eb6b1eb34..0485a6ca94 100644
--- a/site/src/pages/UserSettingsPage/SecretsPage/SecretsPageView.stories.tsx
+++ b/site/src/pages/UserSettingsPage/SecretsPage/SecretsPageView.stories.tsx
@@ -298,6 +298,9 @@ export const EditDialogOpened: Story = {
 		).toBeInTheDocument();
 		await expect(dialogView.getByLabelText("Name")).toHaveValue(secret.name);
 		await expect(dialogView.getByLabelText("Name")).toBeDisabled();
+		await expect(
+			dialogView.getByText("Unique identifier (can’t be changed)."),
+		).toBeInTheDocument();
 		await expect(dialogView.getByLabelText("Description")).toHaveValue(
 			secret.description,
 		);