From 44fff54897ab545c780f310ae837db9b8830a3d1 Mon Sep 17 00:00:00 2001 From: Jaayden Halko Date: Mon, 9 Jun 2025 22:08:34 +0100 Subject: [PATCH] fix: avoid displaying 'everyone' group for idp group sync (#18261) fixes coder/coder#16987 Fix implemented through the coder tasks UI using Coder with Claude Code. Prompt: fix this issue, https://github.com/coder/coder/issues/16987 --- .../IdpSyncPage/IdpGroupSyncForm.tsx | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/site/src/pages/OrganizationSettingsPage/IdpSyncPage/IdpGroupSyncForm.tsx b/site/src/pages/OrganizationSettingsPage/IdpSyncPage/IdpGroupSyncForm.tsx index 284267f448..9282bd6bfd 100644 --- a/site/src/pages/OrganizationSettingsPage/IdpSyncPage/IdpGroupSyncForm.tsx +++ b/site/src/pages/OrganizationSettingsPage/IdpSyncPage/IdpGroupSyncForm.tsx @@ -32,6 +32,7 @@ import { useFormik } from "formik"; import { Plus, Trash, TriangleAlert } from "lucide-react"; import { type FC, type KeyboardEventHandler, useId, useState } from "react"; import { docs } from "utils/docs"; +import { isEveryoneGroup } from "utils/groups"; import { isUUID } from "utils/uuid"; import * as Yup from "yup"; import { ExportPolicyButton } from "./ExportPolicyButton"; @@ -259,15 +260,17 @@ export const IdpGroupSyncForm: FC = ({ className="min-w-60 max-w-3xl" value={coderGroups} onChange={setCoderGroups} - options={groups.map((group) => ({ - label: group.display_name || group.name, - value: group.id, - }))} + options={groups + .filter((group) => !isEveryoneGroup(group)) + .map((group) => ({ + label: group.display_name || group.name, + value: group.id, + }))} hidePlaceholderWhenSelected placeholder="Select group" emptyIndicator={

- All groups selected + No more groups to select

} />