chore(site): align ESLint config to typescript-eslint's recommended-requiring-type-checking (#5797)

site/src/api/api.ts

@@ -20,8 +20,7 @@ export const hardCodedCSRFCookie = (): string => {
 export const withDefaultFeatures = (
   fs: Partial<TypesGen.Entitlements["features"]>,
 ): TypesGen.Entitlements["features"] => {
-  for (const k in TypesGen.FeatureNames) {
-    const feature = k as TypesGen.FeatureName
+  for (const feature of TypesGen.FeatureNames) {
     // Skip fields that are already filled.
     if (fs[feature] !== undefined) {
       continue
@@ -140,8 +139,7 @@ export const getTokens = async (): Promise<TypesGen.APIKey[]> => {
 }
 
 export const deleteAPIKey = async (keyId: string): Promise<void> => {
-  const response = await axios.delete("/api/v2/users/me/keys/" + keyId)
-  return response.data
+  await axios.delete("/api/v2/users/me/keys/" + keyId)
 }
 
 export const getUsers = async (

site/src/pages/TemplateSettingsPage/TemplateSettingsPage.test.tsx

@@ -65,7 +65,7 @@ const fillAndSubmitForm = async ({
   await userEvent.clear(maxTtlField)
   await userEvent.type(maxTtlField, default_ttl_ms.toString())
 
-  const allowCancelJobsField = await screen.getByRole("checkbox")
+  const allowCancelJobsField = screen.getByRole("checkbox")
   // checkbox is checked by default, so it must be clicked to get unchecked
   if (!allow_user_cancel_workspace_jobs) {
     await userEvent.click(allowCancelJobsField)

site/src/pages/UsersPage/UsersPage.test.tsx

@@ -249,7 +249,7 @@ describe("UsersPage", () => {
         expect(API.getUsers).toBeCalledWith({ offset: 0, limit: 25, q: "" }),
       )
 
-      const pageButtons = await container.querySelectorAll(
+      const pageButtons = container.querySelectorAll(
         `button[name="Page button"]`,
       )
       // count handler says there are 2 pages of results

site/src/pages/WorkspacesPage/WorkspacesPage.test.tsx

@@ -49,7 +49,7 @@ describe("WorkspacesPage", () => {
           name: "Previous page",
         })
         expect(prevPage).toBeDisabled()
-        const pageButtons = await container.querySelectorAll(
+        const pageButtons = container.querySelectorAll(
           `button[name="Page button"]`,
         )
         expect(pageButtons.length).toBe(2)

site/src/xServices/users/searchUserXService.ts

@@ -51,9 +51,7 @@ export const searchUserMachine = createMachine(
   {
     services: {
       searchUsers: async (_, { query }) =>
-        await (
-          await getUsers(queryToFilter(query))
-        ).users,
+        (await getUsers(queryToFilter(query))).users,
     },
     actions: {
       assignSearchResults: assign({